You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2010/12/13 13:00:05 UTC
[jira] Created: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
-------------------------------------------------------------------------
Key: SLING-1897
URL: https://issues.apache.org/jira/browse/SLING-1897
Project: Sling
Issue Type: Bug
Components: Engine
Affects Versions: Engine 2.1.0
Reporter: Tobias Bocanegra
example:
slingResponse.setBufferSize(0);
slingResponse.getOutputStream().write(123);
slingResponse.flushBuffer()
does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-1897.
-----------------------------------
> SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
> -------------------------------------------------------------------------
>
> Key: SLING-1897
> URL: https://issues.apache.org/jira/browse/SLING-1897
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.1.0
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: Engine 2.2.0
>
>
> example:
> slingResponse.setBufferSize(0);
> slingResponse.getOutputStream().write(123);
> slingResponse.flushBuffer()
> does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-1897.
--------------------------------------
Resolution: Fixed
Rev. 1062702: Better coordinate internal output buffer handling with servlet container buffering:
- internal commit check for resetBuffer and reset
- setting the buffer size for the engine also sets the same buffer size for the servlet container
- flushBuffer() also calls flushBuffer() on the servlet container's response
(after flushing the internal buffer, if any)
- reset() also resets any internal (engine) buffered data in addition
to resetting the servlet container's response
- resetBuffer() also resets servlet container's buffer in addition to
the internal buffer
> SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
> -------------------------------------------------------------------------
>
> Key: SLING-1897
> URL: https://issues.apache.org/jira/browse/SLING-1897
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.1.0
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: Engine 2.2.0
>
>
> example:
> slingResponse.setBufferSize(0);
> slingResponse.getOutputStream().write(123);
> slingResponse.flushBuffer()
> does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-1897:
----------------------------------------
Assignee: Felix Meschberger
> SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
> -------------------------------------------------------------------------
>
> Key: SLING-1897
> URL: https://issues.apache.org/jira/browse/SLING-1897
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.1.0
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: Engine 2.2.0
>
>
> example:
> slingResponse.setBufferSize(0);
> slingResponse.getOutputStream().write(123);
> slingResponse.flushBuffer()
> does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-1897:
-------------------------------------
Fix Version/s: Engine 2.2.0
Setting this as a blocker for the next release ...
> SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
> -------------------------------------------------------------------------
>
> Key: SLING-1897
> URL: https://issues.apache.org/jira/browse/SLING-1897
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.1.0
> Reporter: Tobias Bocanegra
> Fix For: Engine 2.2.0
>
>
> example:
> slingResponse.setBufferSize(0);
> slingResponse.getOutputStream().write(123);
> slingResponse.flushBuffer()
> does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1897)
SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970787#action_12970787 ]
Tobias Bocanegra commented on SLING-1897:
-----------------------------------------
simple patch that works for me:
Index: src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java
===================================================================
--- src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java (revision 1045074)
+++ src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java (working copy)
@@ -129,6 +129,7 @@
@Override
public void flushBuffer() throws IOException {
getRequestData().getContentData().flushBuffer();
+ getResponse().flushBuffer();
}
@Override
> SlingHttpServletResponseImpl.flushBuffer() does not flush parent response
> -------------------------------------------------------------------------
>
> Key: SLING-1897
> URL: https://issues.apache.org/jira/browse/SLING-1897
> Project: Sling
> Issue Type: Bug
> Components: Engine
> Affects Versions: Engine 2.1.0
> Reporter: Tobias Bocanegra
>
> example:
> slingResponse.setBufferSize(0);
> slingResponse.getOutputStream().write(123);
> slingResponse.flushBuffer()
> does actually bypass the buffer in ContentData, but the flushBuffer is not passed to the wrapped response (neither is setBufferSize())
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.