You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/02/23 07:13:00 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue #783: Can I remove invalid code from the eventmesh-runtime module?
Alonexc opened a new issue #783:
URL: https://github.com/apache/incubator-eventmesh/issues/783
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Question
There is a lot of invalid code in the EventMesh-Runtime module, for example:
<img width="863" alt="Screen Shot 2022-02-23 at 14 48 02" src="https://user-images.githubusercontent.com/91315508/155272774-14a06bba-6d15-4bb1-9874-a03d26d4b4b2.png">
<img width="893" alt="Screen Shot 2022-02-23 at 14 49 38" src="https://user-images.githubusercontent.com/91315508/155272925-137bbc26-b16d-4af0-9071-0396c223f91c.png">
Located in:
1.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util package.
2.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/patch: EventMeshConsumeConcurrentlyContext.java and EventMeshMessageListenerConcurrently.java
3.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/domain under this package has a few class is commented.
4.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/consumer package.
5.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor package.
6.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java
7.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java
8.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/ClientAckContext.java
9.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/DownStreamMsgContext.java
10.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/SessionPusher.java
11.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/send/SessionSender.java
12.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/Session.java
13.eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task package
Suggestion: Delete invalid code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #783: [Question] Can I remove invalid code from the eventmesh-runtime module?
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #783:
URL: https://github.com/apache/incubator-eventmesh/issues/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] sarihuangshanrong commented on issue #783: [Question] Can I remove invalid code from the eventmesh-runtime module?
Posted by GitBox <gi...@apache.org>.
sarihuangshanrong commented on issue #783:
URL: https://github.com/apache/incubator-eventmesh/issues/783#issuecomment-1048529781
let me do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #783: [Question] Can I remove invalid code from the eventmesh-runtime module?
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #783:
URL: https://github.com/apache/incubator-eventmesh/issues/783#issuecomment-1048532033
> 让我这样做。
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org