You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2022/06/03 18:01:14 UTC

[datasketches-cpp] branch kll_converting_constructor created (now 5f6eb9b)

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a change to branch kll_converting_constructor
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git


      at 5f6eb9b  added missing serde parameter

This branch includes the following new commits:

     new 5f6eb9b  added missing serde parameter

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[datasketches-cpp] 01/01: added missing serde parameter

Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch kll_converting_constructor
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git

commit 5f6eb9baf6a5baa2c348c95b8aa323ea03030c93
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Fri Jun 3 11:01:09 2022 -0700

    added missing serde parameter
---
 kll/include/kll_sketch.hpp      | 4 ++--
 kll/include/kll_sketch_impl.hpp | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/kll/include/kll_sketch.hpp b/kll/include/kll_sketch.hpp
index bd6d0c4..d1e11d6 100644
--- a/kll/include/kll_sketch.hpp
+++ b/kll/include/kll_sketch.hpp
@@ -187,8 +187,8 @@ class kll_sketch {
      * @param other sketch of a different type
      * @param allocator instance of an Allocator
      */
-    template<typename TT, typename CC, typename AA>
-    explicit kll_sketch(const kll_sketch<TT, CC, AA> & other, const A& allocator = A());
+    template<typename TT, typename CC, typename SS, typename AA>
+    explicit kll_sketch(const kll_sketch<TT, CC, SS, AA>& other, const A& allocator = A());
 
     /**
      * Updates this sketch with the given data item.
diff --git a/kll/include/kll_sketch_impl.hpp b/kll/include/kll_sketch_impl.hpp
index 2337b24..703a940 100644
--- a/kll/include/kll_sketch_impl.hpp
+++ b/kll/include/kll_sketch_impl.hpp
@@ -149,8 +149,8 @@ kll_sketch<T, C, S, A>::~kll_sketch() {
 }
 
 template<typename T, typename C, typename S, typename A>
-template<typename TT, typename CC, typename AA>
-kll_sketch<T, C, S, A>::kll_sketch(const kll_sketch<TT, CC, AA>& other, const A& allocator):
+template<typename TT, typename CC, typename SS, typename AA>
+kll_sketch<T, C, S, A>::kll_sketch(const kll_sketch<TT, CC, SS, AA>& other, const A& allocator):
 allocator_(allocator),
 k_(other.get_k()),
 m_(DEFAULT_M),


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org