You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/03 13:45:04 UTC

[GitHub] [airflow] uranusjr edited a comment on pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

uranusjr edited a comment on pull request #16352:
URL: https://github.com/apache/airflow/pull/16352#issuecomment-891859321


   Note: I’ve changed `schedule_date` in this PR to `logical_date` as I mentioned on the dev mailing list: https://lists.apache.org/thread.html/r00d88d22ae15f9c98b91c8f28163c09e59fb4a6436586861c69a66b7%40%3Cdev.airflow.apache.org%3E
   
   @eladkal said he doesn’t particularly like the name and plans to share some thoughts on the mailing list. But I’m going to use `logical_date` for now since we need to use _something_ (AIP-39 implementation would be greatly delayed if we block this PR until the name issue is fully resolved), and `logical_date` is already better than `schedule_date`. We can always mass-replace all the occurences (like I did in the rename commit) when we settle on something else 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org