You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/31 10:57:20 UTC
[GitHub] [nifi-site] szaszm commented on a diff in pull request #64: MINIFICPP-1844 - Add MiNiFi C++ 0.12.0 to the downloads page
szaszm commented on code in PR #64:
URL: https://github.com/apache/nifi-site/pull/64#discussion_r885496418
##########
src/pages/html/minifi/download.hbs:
##########
@@ -51,68 +51,53 @@ title: Apache NiFi - MiNiFi Downloads
</ul>
<h3>MiNiFi C++</h3>
<ul>
- <li>cpp-0.11.0
+ <li>cpp-0.12.0
<ul>
<li>
Sources:
<ul>
- <li><a href="https://www.apache.org/dyn/closer.lua?path=/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-source.tar.gz">nifi-minifi-cpp-0.11.0-source.tar.gz</a>
- ( <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-source.tar.gz.asc">asc</a>,
- <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-source.tar.gz.sha256">sha256</a> )
+ <li><a href="https://www.apache.org/dyn/closer.lua?path=/nifi/nifi-minifi-cpp/0.12.0/nifi-minifi-cpp-0.12.0-source.tar.gz">nifi-minifi-cpp-0.12.0-source.tar.gz</a>
+ ( <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.12.0/nifi-minifi-cpp-0.12.0-source.tar.gz.asc">asc</a>,
+ <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.12.0/nifi-minifi-cpp-0.12.0-source.tar.gz.sha256">sha256</a> )
</li>
</ul>
</li>
<li>
Binaries
<ul>
Linux (CentOS 7, Debian 10, Fedora 34, Ubuntu 20.04) - x86_64
- <li><a href="https://www.apache.org/dyn/closer.lua?path=/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-bin-linux.tar.gz">nifi-minifi-cpp-0.11.0-bin-linux.tar.gz</a>
- ( <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-bin-linux.tar.gz.asc">asc</a>,
- <a href="https://downloads.apache.org/nifi/nifi-minifi-cpp/0.11.0/nifi-minifi-cpp-0.11.0-bin-linux.tar.gz.sha256">sha256</a> )
+ <li><a href="https://www.apache.org/dyn/closer.lua?path=/nifi/nifi-minifi-cpp/0.12.0/nifi-minifi-cpp-0.12.0-bin-linux.tar.gz">nifi-minifi-cpp-0.12.0-bin-linux.tar.gz</a>
Review Comment:
I can't start a thread on that line, but I think we should add "or newer" at the end of the Linux version list, since these binaries work on anything newer than CentOS 7's (ancient) version of glibc and libstdc++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org