[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4881: libc: Update include/nuttx/input/x11_keysymdef.h to the latest version

[GitBox <gi...@apache.org>]

xiaoxiang781216 edited a comment on pull request #4881:
URL: https://github.com/apache/incubator-nuttx/pull/4881#issuecomment-990609051


   > > > it seems a bit awkward to have x11 stuff in libc.
   > > 
   > > 
   > > I agree. Not just awkward but wrong. The content of libc is controlled by POSIX/ANSI standards (plus glibc compatibility). We cannot just put anything we want into libc,
   > > This belong in libx11, right?
   > 
   
   VNC server use x11 key symbols, because the spec define the key event on top of x11's:
   https://datatracker.ietf.org/doc/html/rfc6143#page-16
   So, the intention just introduce x11 key event macro and some simple conversion utility function, I think nobody plan to port or implement x11 currently. That is why @patacongo add x11_ prefix  to the header files and put them into a special location(include/nuttx/input/) in the initial patch: https://github.com/apache/incubator-nuttx/commit/48b00cd873e67bb716387a8eb35048a7405bc42f
   which clearly indicate that we just use x11 key macro definition here, not the full feature x11. 
   
   > i agree it's cleaner to have a separate library.
   
   Anyway, I will remove the API from the patch, let's focus on the header file change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org