You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kr...@apache.org on 2015/11/19 07:53:38 UTC

svn commit: r1715110 - /maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java

Author: krosenvold
Date: Thu Nov 19 06:53:38 2015
New Revision: 1715110

URL: http://svn.apache.org/viewvc?rev=1715110&view=rev
Log:
Fixed file handle leak

Modified:
    maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java

Modified: maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java?rev=1715110&r1=1715109&r2=1715110&view=diff
==============================================================================
--- maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java (original)
+++ maven/plugins/trunk/maven-remote-resources-plugin/src/main/java/org/apache/maven/plugin/resources/remote/BundleRemoteResourcesMojo.java Thu Nov 19 06:53:38 2015
@@ -27,6 +27,7 @@ import org.apache.maven.plugins.annotati
 import org.apache.maven.plugins.annotations.Parameter;
 import org.codehaus.plexus.util.DirectoryScanner;
 import org.codehaus.plexus.util.FileUtils;
+import org.codehaus.plexus.util.IOUtil;
 import org.codehaus.plexus.util.ReaderFactory;
 import org.codehaus.plexus.util.StringUtils;
 
@@ -138,13 +139,15 @@ public class BundleRemoteResourcesMojo
 
         RemoteResourcesBundleXpp3Writer w = new RemoteResourcesBundleXpp3Writer();
 
+        Writer writer = null;
         try
         {
             File f = new File( outputDirectory, RESOURCES_MANIFEST );
 
-            FileUtils.mkdir( f.getParentFile().getAbsolutePath() );
+            FileUtils.mkdir( f.getParentFile()
+                              .getAbsolutePath() );
 
-            Writer writer = new FileWriter( f );
+            writer = new FileWriter( f );
 
             w.write( writer, remoteResourcesBundle );
         }
@@ -152,5 +155,9 @@ public class BundleRemoteResourcesMojo
         {
             throw new MojoExecutionException( "Error creating remote resources manifest.", e );
         }
+        finally
+        {
+            IOUtil.close( writer );
+        }
     }
 }