You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chi Zhang <ch...@gmail.com> on 2015/04/29 01:00:07 UTC
Review Request 33644: MemoryTestHelper: Changed to do memset before
mlock.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33644/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: mesos-2660
https://issues.apache.org/jira/browse/mesos-2660
Repository: mesos
Description
-------
In allocateRSS, when requested memory is more than the limit, mlock returns
error because it couldn't find enough lockable memory, which defeats the
purpose to trigger an oom.
Diffs
-----
src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
Diff: https://reviews.apache.org/r/33644/diff/
Testing
-------
Thanks,
Chi Zhang
Re: Review Request 33644: MemoryTestHelper: Changed to do memset
before mlock.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33644/#review81904
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33644]
All tests passed.
- Mesos ReviewBot
On April 28, 2015, 11 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33644/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-2660
> https://issues.apache.org/jira/browse/mesos-2660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In allocateRSS, when requested memory is more than the limit, mlock returns
> error because it couldn't find enough lockable memory, which defeats the
> purpose to trigger an oom.
>
>
> Diffs
> -----
>
> src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
>
> Diff: https://reviews.apache.org/r/33644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>
Re: Review Request 33644: MemoryTestHelper: Changed to do memset
before mlock.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33644/#review81899
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 28, 2015, 11 p.m., Chi Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33644/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: mesos-2660
> https://issues.apache.org/jira/browse/mesos-2660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In allocateRSS, when requested memory is more than the limit, mlock returns
> error because it couldn't find enough lockable memory, which defeats the
> purpose to trigger an oom.
>
>
> Diffs
> -----
>
> src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51
>
> Diff: https://reviews.apache.org/r/33644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chi Zhang
>
>