You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/02/25 21:45:45 UTC
svn commit: r1732364 - in /jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
xdocs/changes.xml
Author: pmouawad
Date: Thu Feb 25 20:45:45 2016
New Revision: 1732364
URL: http://svn.apache.org/viewvc?rev=1732364&view=rev
Log:
Bug 59069 - CookieManager : Selected Cookie Policy is always reset to default when saving or switching to another TestElement (nightly build 25th feb 2016)
Bugzilla Id: 59069
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
jmeter/trunk/xdocs/changes.xml
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java?rev=1732364&r1=1732363&r2=1732364&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java Thu Feb 25 20:45:45 2016
@@ -222,7 +222,9 @@ public class CookiePanel extends Abstrac
JMeterUtils.reportErrorToUser(ex.getMessage(), "Error saving cookies");
}
} else if (action.equals(HANDLER_COMMAND)) {
+ String currentPolicy = policy.getText();
policy.setValues(getPolicies(handlerMap.get(selectHandlerPanel.getSelectedItem())));
+ policy.setText(currentPolicy);
}
}
Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1732364&r1=1732363&r2=1732364&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Thu Feb 25 20:45:45 2016
@@ -265,6 +265,7 @@ Summary
<li><bug>57935</bug>SSL SNI extension not supported by HttpClient 4.2.6</li>
<li><bug>59044</bug>Http Sampler : It should not be possible to select the multipart encoding if the method is not POST. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
<li><bug>59008</bug>Http Sampler: Infinite recursion SampleResult on frame depth limit reached</li>
+ <li><bug>59069</bug>CookieManager : Selected Cookie Policy is always reset to default when saving or switching to another TestElement (nightly build 25th feb 2016)</li>
</ul>
<h3>Other Samplers</h3>
Re: svn commit: r1732364 - in /jmeter/trunk: src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
xdocs/changes.xml
Posted by sebb <se...@gmail.com>.
On 25 February 2016 at 20:45, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Thu Feb 25 20:45:45 2016
> New Revision: 1732364
>
> URL: http://svn.apache.org/viewvc?rev=1732364&view=rev
> Log:
> Bug 59069 - CookieManager : Selected Cookie Policy is always reset to default when saving or switching to another TestElement (nightly build 25th feb 2016)
>
> Bugzilla Id: 59069
>
> Modified:
> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
> jmeter/trunk/xdocs/changes.xml
>
> Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java?rev=1732364&r1=1732363&r2=1732364&view=diff
> ==============================================================================
> --- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java (original)
> +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java Thu Feb 25 20:45:45 2016
> @@ -222,7 +222,9 @@ public class CookiePanel extends Abstrac
> JMeterUtils.reportErrorToUser(ex.getMessage(), "Error saving cookies");
> }
> } else if (action.equals(HANDLER_COMMAND)) {
> + String currentPolicy = policy.getText();
> policy.setValues(getPolicies(handlerMap.get(selectHandlerPanel.getSelectedItem())));
> + policy.setText(currentPolicy);
> }
> }
>
>
> Modified: jmeter/trunk/xdocs/changes.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1732364&r1=1732363&r2=1732364&view=diff
> ==============================================================================
> --- jmeter/trunk/xdocs/changes.xml (original)
> +++ jmeter/trunk/xdocs/changes.xml Thu Feb 25 20:45:45 2016
> @@ -265,6 +265,7 @@ Summary
> <li><bug>57935</bug>SSL SNI extension not supported by HttpClient 4.2.6</li>
> <li><bug>59044</bug>Http Sampler : It should not be possible to select the multipart encoding if the method is not POST. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
> <li><bug>59008</bug>Http Sampler: Infinite recursion SampleResult on frame depth limit reached</li>
> + <li><bug>59069</bug>CookieManager : Selected Cookie Policy is always reset to default when saving or switching to another TestElement (nightly build 25th feb 2016)</li>
I think this entry needs to be removed.
The changes list is supposed to document the changes since the
previous version (i.e. 2.13); bug 59069 does not apply to 2.13
It's very confusing if the changes list includes something that
applies only to a build that has never been released.
The original bug should be updated with the additional fix as that
should have been done as part of the original changes.
> </ul>
>
> <h3>Other Samplers</h3>
>
>