You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "edgarRd (via GitHub)" <gi...@apache.org> on 2026/07/10 17:16:39 UTC
[PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
edgarRd opened a new pull request, #17157:
URL: https://github.com/apache/iceberg/pull/17157
`ParquetConversions.converterFromParquet` special-cased only the `UTF8` original type, so for `ENUM`- or `JSON`-annotated Parquet columns it fell through to the binary path and returned a `ByteBuffer`. Iceberg maps both `ENUM` and `JSON` to `StringType` (see `MessageTypeToType`), so at read time the metrics/dictionary row-group filters compared that `ByteBuffer` against a `CharSequence` predicate literal and threw:
```
class java.nio.HeapByteBuffer cannot be cast to class java.lang.CharSequence
```
This is reachable for files written by other engines (e.g. Flink, which uses JSON columns) and added via `add_files`: querying such a column with a predicate triggers row-group filtering.
This change treats `ENUM` and `JSON` like `UTF8` and decodes them to a `CharSequence`. The import/metrics path (`ParquetConversions.convertValue`) already switches on the Iceberg type and was unaffected.
Adds `TestParquetConversions` covering the ENUM/JSON conversion paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#discussion_r3900367091
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetConversions.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.parquet;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.iceberg.types.Types;
+import org.apache.parquet.io.api.Binary;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+import org.apache.parquet.schema.PrimitiveType;
+import org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName;
+import org.junit.jupiter.api.Test;
+
+public class TestParquetConversions {
+
+ private static PrimitiveType binaryWith(LogicalTypeAnnotation annotation) {
+ return org.apache.parquet.schema.Types.required(PrimitiveTypeName.BINARY)
+ .as(annotation)
+ .named("s");
+ }
+
+ @Test
+ public void testStringConverterDecodesUtf8EnumAndJson() {
Review Comment:
remove test prefix for newly added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#discussion_r3900397176
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java:
##########
@@ -94,6 +94,12 @@ static Function<Object, Object> converterFromParquet(PrimitiveType type) {
if (type.getOriginalType() != null) {
switch (type.getOriginalType()) {
case UTF8:
+ case ENUM:
+ case JSON:
+ // ENUM and JSON are UTF-8 strings that map to Iceberg StringType (see MessageTypeToType),
+ // so they must be decoded to a CharSequence like UTF8; otherwise read-time row-group
+ // filters compare a ByteBuffer against a CharSequence literal and throw
+ // ClassCastException
Review Comment:
Can we add a more end-to -end test that throws `ClassCastException` without this change?
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java:
##########
@@ -94,6 +94,12 @@ static Function<Object, Object> converterFromParquet(PrimitiveType type) {
if (type.getOriginalType() != null) {
switch (type.getOriginalType()) {
case UTF8:
+ case ENUM:
+ case JSON:
+ // ENUM and JSON are UTF-8 strings that map to Iceberg StringType (see MessageTypeToType),
+ // so they must be decoded to a CharSequence like UTF8; otherwise read-time row-group
+ // filters compare a ByteBuffer against a CharSequence literal and throw
+ // ClassCastException
Review Comment:
Can we add a more end-to-end test that throws `ClassCastException` without this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#discussion_r3989970539
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetMetricsRowGroupFilter.java:
##########
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.parquet;
+
+import static org.apache.iceberg.expressions.Expressions.equal;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.stream.Stream;
+import org.apache.iceberg.Files;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.types.Types.StringType;
+import org.apache.parquet.example.data.Group;
+import org.apache.parquet.example.data.simple.SimpleGroupFactory;
+import org.apache.parquet.hadoop.ParquetFileReader;
+import org.apache.parquet.hadoop.ParquetWriter;
+import org.apache.parquet.hadoop.example.ExampleParquetWriter;
+import org.apache.parquet.hadoop.metadata.BlockMetaData;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+import org.apache.parquet.schema.MessageType;
+import org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName;
+import org.apache.parquet.schema.Types;
+import org.junit.jupiter.api.io.TempDir;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
+
+class TestParquetMetricsRowGroupFilter {
Review Comment:
I looked at TestMetricsRowGroupFilter, and I can understand why we couldn't add these cases there because we can't really express in that module the ability to pass in a parquet schema with the neccesary preconditions to reproduce this issue (enum/json logical types). But it does feel like at some point we should refactor these tests so we can actually test data type conversion and filtering logic independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17157: Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions
URL: https://github.com/apache/iceberg/pull/17157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5628856066
LGTM. @huaxingao @amogh-jahagirdar Could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on code in PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#discussion_r3985440018
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetConversions.java:
##########
@@ -94,6 +94,12 @@ static Function<Object, Object> converterFromParquet(PrimitiveType type) {
if (type.getOriginalType() != null) {
switch (type.getOriginalType()) {
case UTF8:
+ case ENUM:
+ case JSON:
+ // ENUM and JSON are UTF-8 strings that map to Iceberg StringType (see MessageTypeToType),
+ // so they must be decoded to a CharSequence like UTF8; otherwise read-time row-group
+ // filters compare a ByteBuffer against a CharSequence literal and throw
+ // ClassCastException
Review Comment:
With the new included end-to-end (`creation → metadata reading → row-group filtering`) test, I verified that removing the `ENUM`/`JSON` conversion fix makes both parameterized cases throw the original `ClassCastException` in `Comparators.CharSeqComparator.compare(...)`.
It does not exercise a full table import, SQL query, or row materialization given that the original end-to-end way that I found the issue was with and older version of Flink-generated files writing directly to S3 - any other existing writer in Iceberg (at a higher level) would not hit this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5628596773
@manuzhang I believe I've addressed the comments. Let me know if there's anything else missing. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5642151484
> Thanks for your patience @edgarRd , the fix looks right to me. I do think at some point we need to refactor the tests a bit so we can better test the "conversion" part of ParquetConversions in a more general way vs the Filtering. The change does that by introducing 2 new test classes but we do have TestMetricsRowGroupFiltering already, and it'd be nice to see if we just need to change that to generalize a bit more. Maybe the ParquetConversions tests should standalone and test the matrix of data conversions.
>
> Either way, nothing blocking , I'll go ahead and merge.
I agree on the test refactor as a follow-up. I’ll look into it and see if I can put together a separate PR with an approach that makes sense.
Thanks for the review, @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5152987400
PTAL @ndrluis @manuzhang @nastra @huaxingao — this is similar to #14027, fixing a `ClassCastException` in Parquet row-group filter conversion, this time for ENUM/JSON string annotations. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#discussion_r3900373340
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetConversions.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.parquet;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.apache.iceberg.types.Types;
+import org.apache.parquet.io.api.Binary;
+import org.apache.parquet.schema.LogicalTypeAnnotation;
+import org.apache.parquet.schema.PrimitiveType;
+import org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName;
+import org.junit.jupiter.api.Test;
+
+public class TestParquetConversions {
+
+ private static PrimitiveType binaryWith(LogicalTypeAnnotation annotation) {
+ return org.apache.parquet.schema.Types.required(PrimitiveTypeName.BINARY)
+ .as(annotation)
+ .named("s");
+ }
+
+ @Test
+ public void testStringConverterDecodesUtf8EnumAndJson() {
+ Binary value = Binary.fromString("hello");
+
+ // UTF8, ENUM and JSON all map to Iceberg StringType (MessageTypeToType), so the converter must
Review Comment:
This comment doesn't add much value to the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar merged PR #17157:
URL: https://github.com/apache/iceberg/pull/17157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-4937778268
PTAL @amogh-jahagirdar when you have a chance. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5486732572
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-4939390920
cc @Parth-Brahmbhatt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5053164472
Friendly ping @amogh-jahagirdar - happy to redirect to someone else that could take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5646611281
Thanks @edgarRd for the fix and thanks @manuzhang for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5594374144
@edgarRd This was closed due to lack of activity. I suppose you still want to work on it so reopening it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "edgarRd (via GitHub)" <gi...@apache.org>.
edgarRd commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5594408254
Thanks @manuzhang - I'll work on addressing your comments tomorrow. I appreciate your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Parquet: Decode ENUM/JSON columns as UTF-8 in row-group filter conversions [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17157:
URL: https://github.com/apache/iceberg/pull/17157#issuecomment-5593856859
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org