You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2008/08/12 18:21:45 UTC

svn commit: r685217 - in /hadoop/hbase: branches/0.2/CHANGES.txt branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java trunk/CHANGES.txt trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Author: stack
Date: Tue Aug 12 09:21:44 2008
New Revision: 685217

URL: http://svn.apache.org/viewvc?rev=685217&view=rev
Log:
HBASE-818 Deadlock running 'flushSomeRegions'

Modified:
    hadoop/hbase/branches/0.2/CHANGES.txt
    hadoop/hbase/branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java

Modified: hadoop/hbase/branches/0.2/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.2/CHANGES.txt?rev=685217&r1=685216&r2=685217&view=diff
==============================================================================
--- hadoop/hbase/branches/0.2/CHANGES.txt (original)
+++ hadoop/hbase/branches/0.2/CHANGES.txt Tue Aug 12 09:21:44 2008
@@ -11,6 +11,7 @@
                invalidating entries (Andrew Purtell via Stack)
    HBASE-819   Remove DOS-style ^M carriage returns from all code where found
                (Jonathan Gray via Jim Kellerman)
+   HBASE-818   Deadlock running 'flushSomeRegions' (Andrew Purtell via Stack)
 
   IMPROVEMENTS
    HBASE-801  When a table haven't disable, shell could response in a "user

Modified: hadoop/hbase/branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=685217&r1=685216&r2=685217&view=diff
==============================================================================
--- hadoop/hbase/branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hadoop/hbase/branches/0.2/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java Tue Aug 12 09:21:44 2008
@@ -1624,8 +1624,9 @@
         return;
       }
       writestate.flushRequested = true;
-      this.flushListener.request(this);
     }
+    // Make request outside of synchronize block; HBASE-818.
+    this.flushListener.request(this);
     if (LOG.isDebugEnabled()) {
       LOG.debug("Flush requested on " + this);
     }

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=685217&r1=685216&r2=685217&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Tue Aug 12 09:21:44 2008
@@ -11,6 +11,7 @@
                invalidating entries (Andrew Purtell via Stack)
    HBASE-819   Remove DOS-style ^M carriage returns from all code where found
                (Jonathan Gray via Jim Kellerman)
+   HBASE-818   Deadlock running 'flushSomeRegions' (Andrew Purtell via Stack)
 
   IMPROVEMENTS
    HBASE-801  When a table haven't disable, shell could response in a "user

Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java?rev=685217&r1=685216&r2=685217&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HRegion.java Tue Aug 12 09:21:44 2008
@@ -1624,8 +1624,9 @@
         return;
       }
       writestate.flushRequested = true;
-      this.flushListener.request(this);
     }
+    // Make request outside of synchronize block; HBASE-818.
+    this.flushListener.request(this);
     if (LOG.isDebugEnabled()) {
       LOG.debug("Flush requested on " + this);
     }