[GitHub] [maven-verifier] kwin commented on a change in pull request #6: [MSHARED-1015] correctly set system property

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #6:
URL: https://github.com/apache/maven-verifier/pull/6#discussion_r777988147



##########
File path: src/main/java/org/apache/maven/it/Embedded3xLauncher.java
##########
@@ -268,4 +271,26 @@ public String getMavenVersion()
         throw new LauncherException( "Could not determine embedded Maven version" );
     }
 
+    /**
+     * Replicates the logic from <a href="https://git.io/JSMug">Maven start script</a> to find 
+     * the project's base directory.
+     * @param workingDirectory the working directory
+     * @return the project's base directory
+     */
+    private static File findProjectBaseDirectory( File workingDirectory )
+    {
+        File folder = workingDirectory;

Review comment:
       fixed in https://github.com/apache/maven-verifier/pull/6/commits/1a232adec518cfba6d63fb742b63ac50b1d868e7.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org