You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (Jira)" <ji...@apache.org> on 2020/10/13 08:50:00 UTC
[jira] [Commented] (FLINK-19593) FlinkKafkaInternalProducer should
be @Internal annotation ?
[ https://issues.apache.org/jira/browse/FLINK-19593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212955#comment-17212955 ]
Aljoscha Krettek commented on FLINK-19593:
------------------------------------------
I think there are too many inconsistencies in how the {{@Internal}} annotation is applied to connector code (and some other code as well). I don't think it will be helpful to open Jira issues for every single file. What we would need is a comprehensive audit after which we could consistently apply the annotations.
> FlinkKafkaInternalProducer should be @Internal annotation ?
> -----------------------------------------------------------
>
> Key: FLINK-19593
> URL: https://issues.apache.org/jira/browse/FLINK-19593
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Kafka
> Affects Versions: 1.11.2
> Reporter: Kenzyme Le
> Priority: Minor
>
> Hello,
> Seems like [ FlinkKafkaInternalProducer|https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/FlinkKafkaInternalProducer.java] should be marked as @Internal instead of @PublicEvolving?
> If it should be modified, I would be happy to make the change.
> Thank you for the clarification!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)