You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/20 07:15:08 UTC
Review Request 21682: Removing tests related to sparse and fat volume
provisioning from 4.4-forward. This feature is not part of 4.4 release.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21682/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Repository: cloudstack-git
Description
-------
This patch related to volume provisioning feature (https://reviews.apache.org/r/19446/) is only part of master and will be part of 4.5 release. Unit tests related to this feature should not be present in 4.4-forward branch. They might have come into this branch during marvin merging work. So removing these tests.
In future they will be included as a part of cherry-picking the patch to appropriate branch.
The patch should be applied to only 4.4-forward branch, NOT master.
Diffs
-----
test/integration/smoke/test_disk_offerings.py 780c154
test/integration/smoke/test_volumes.py a151df9
Diff: https://reviews.apache.org/r/21682/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 21682: Removing tests related to sparse and fat volume
provisioning from 4.4-forward. This feature is not part of 4.4 release.
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
> On May 20, 2014, 4:16 p.m., Yoshikazu Nojima wrote:
> > Ship It!
Oh, it's already shipped.
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=f278c537d527aa0a9cf0e20cf80dd48e1d85ec82
- Yoshikazu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21682/#review43488
-----------------------------------------------------------
On May 20, 2014, 5:15 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21682/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 5:15 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch related to volume provisioning feature (https://reviews.apache.org/r/19446/) is only part of master and will be part of 4.5 release. Unit tests related to this feature should not be present in 4.4-forward branch. They might have come into this branch during marvin merging work. So removing these tests.
>
> In future they will be included as a part of cherry-picking the patch to appropriate branch.
>
> The patch should be applied to only 4.4-forward branch, NOT master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_disk_offerings.py 780c154
> test/integration/smoke/test_volumes.py a151df9
>
> Diff: https://reviews.apache.org/r/21682/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21682: Removing tests related to sparse and fat volume
provisioning from 4.4-forward. This feature is not part of 4.4 release.
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21682/#review43488
-----------------------------------------------------------
Ship it!
Ship It!
- Yoshikazu Nojima
On May 20, 2014, 5:15 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21682/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 5:15 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch related to volume provisioning feature (https://reviews.apache.org/r/19446/) is only part of master and will be part of 4.5 release. Unit tests related to this feature should not be present in 4.4-forward branch. They might have come into this branch during marvin merging work. So removing these tests.
>
> In future they will be included as a part of cherry-picking the patch to appropriate branch.
>
> The patch should be applied to only 4.4-forward branch, NOT master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_disk_offerings.py 780c154
> test/integration/smoke/test_volumes.py a151df9
>
> Diff: https://reviews.apache.org/r/21682/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 21682: Removing tests related to sparse and fat volume
provisioning from 4.4-forward. This feature is not part of 4.4 release.
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21682/#review43462
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 20, 2014, 5:15 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21682/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 5:15 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch related to volume provisioning feature (https://reviews.apache.org/r/19446/) is only part of master and will be part of 4.5 release. Unit tests related to this feature should not be present in 4.4-forward branch. They might have come into this branch during marvin merging work. So removing these tests.
>
> In future they will be included as a part of cherry-picking the patch to appropriate branch.
>
> The patch should be applied to only 4.4-forward branch, NOT master.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_disk_offerings.py 780c154
> test/integration/smoke/test_volumes.py a151df9
>
> Diff: https://reviews.apache.org/r/21682/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>