Re: Jsr305, Take 2

[Jeff Jensen <je...@upstairstechnology.com>]

On Tue, Sep 23, 2014 at 11:05 PM, Hervé BOUTEMY <he...@free.fr>
wrote:

> Le lundi 22 septembre 2014 18:14:52 Kristian Rosenvold a écrit :
> >  <dependency>
> >           <groupId>com.google.code.findbugs</groupId>
> >           <artifactId>jsr305</artifactId>
> >           <version>3.0.0</version>
> >           <scope>provided</scope>
> >     </dependency>
> >
> > The reason for this is that the findbugs project has been evolving
> > these annotations at a pace, and I would now also like to use
> > @CheckForNull, @CheckReturnValue, @OverridingMethodsMustInvokeSuper,
> > @WillClose and @WillNotClose.
> >
> > (CheckReturnValue makes it an error NOT to check the return value,
> > which is good for immutable classes...)
> >
> > I think these annotations are particularly valuable in shared code
> > (maven-shared and all of plexus).
> +1
>
> and with provided scope, I don't see any drawback
> version 1.3.7 was LGPL (as stated in the POM), but version 3.0.0 is AL, so
> I
> don't see any problem
>
> Regards,
>
> Hervé
>
> >
> > Kristian
> >
> > 2014-09-22 18:10 GMT+02:00 Kristian Rosenvold
> <kr...@gmail.com>:
> > > Some time ago, we discussed using the JSR305 annotations. At the time
> we
> > > discussed @Nonnull and @Nullable, and it turned out that those two
> > > annotations are "named based" in most analysis-tools; you can make your
> > > own
> > > org.apache.maven.annotations.Nonnull/Nullable and have a reasonable
> chance
> > > of having tools pick them up. Both findbugs and IntelliJ support this
> > > approach. We sort-of concluded that this would be the optimal approach,
> > > and
> > > since then we promptly did nothing about it :)
> > >
> > > I'm very happy that we didn't do anything about it, since I'd now like
> to
> > > re-propose that we actually use
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>