[GitHub] [flink] hequn8128 commented on a change in pull request #10055: [FLINK-14573][python] Support time data types in Python user-defined functions

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #10055: [FLINK-14573][python] Support time data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/10055#discussion_r354098677
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/TimestampSerializer.java
 ##########
 @@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.typeutils.serializers.python;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.api.common.typeutils.TypeSerializerSchemaCompatibility;
+import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.base.TypeSerializerSingleton;
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.DataOutputView;
+import org.apache.flink.table.dataformat.SqlTimestamp;
+import org.apache.flink.table.runtime.typeutils.SqlTimestampSerializer;
+
+import java.io.IOException;
+import java.sql.Timestamp;
+
+/**
+ * Uses SqlTimestampSerializer to serialize Timestamp. It not only deals with Daylight saving time
+ * problem and precision problem, but also makes the serialized value consistent between the legacy
+ * planner and the blink planner.
+ */
+@Internal
+public class TimestampSerializer extends TypeSerializerSingleton<Timestamp> {
+
+	private static final long serialVersionUID = 1L;
+
+	private final transient SqlTimestampSerializer sqlTimestampSerializer;
 
 Review comment:
   We can't depend on Blink class by default. Theoretically, there will be only flink planner on the classpath.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services