You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/08 02:14:33 UTC

[GitHub] [beam] lukecwik commented on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

lukecwik commented on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038


   R: @robertwb @chamikaramj 
   
   Style-wise does it make sense to use the `kwargs` to pass these through or should I continue to make them explicit like the `restriction_tracker` and `watermark_estimator` that was provided before.
   
   Alternatively, I could move the window observing logic outside of the DoFnInvoker and then all the DoFnRunners would own this logic.
   
   WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org