[GitHub] ccollins476ad opened a new pull request #232: Use syscfg settings for sysinit stage numbers

[GitBox <gi...@apache.org>]

ccollins476ad opened a new pull request #232: Use syscfg settings for sysinit stage numbers
URL: https://github.com/apache/mynewt-nimble/pull/232
 
 
   **DO NOT MERGE:** This PR requires a newt change to be merged first: https://github.com/apache/mynewt-newt/pull/230
   
   This allows the app or target to rearrange package initialization order via syscfg overrides.
   
   **Note: This requires an updated version of newt
   (https://github.com/apache/mynewt-newt/pull/230).  Older versions of newt fail to parse the updated `pkg.yml` files.
   
   I wanted to make this change backwards compatible via an injected newt syscfg setting, e.g.,
   ```
   pkg.init.NEWT_FEATURE_SYSCFG_STAGES:
       log_init: 'MYNEWT_VAL(LOG_SYSINIT_STAGE)'
   
   pkg.init.!NEWT_FEATURE_SYSCFG_STAGES:
       log_init: 100
   ```
   
   Unfortunately, this is not possible, as the old newt does not allow conditionals to be applied to `pkg.init`.  So, as soon as this PR is merged, everything will break for users using older versions of newt.
   
   I think it is still worth it to get this change in.  Before we merge, we can send a note to the dev list and the slack channel.  When 1.6.0 is released, we can make sure to add the appropriate newt version restriction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services