You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/16 05:50:44 UTC

[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #6222: [Fix-6220] [API] New tenant name could be "default"

JinyLeeChina commented on a change in pull request #6222:
URL: https://github.com/apache/dolphinscheduler/pull/6222#discussion_r709792864



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TenantServiceImpl.java
##########
@@ -95,7 +95,8 @@
             return result;
         }
 
-        if (checkTenantExists(tenantCode)) {
+        // check if tenant exists in database or named "default"
+        if (checkTenantExists(tenantCode) || "default".equalsIgnoreCase(tenantCode)) {

Review comment:
       Why not allow tenants to be set to 'default' ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org