You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "abhishek bafna (JIRA)" <ji...@apache.org> on 2016/04/25 13:52:12 UTC
[jira] [Commented] (OOZIE-2465) CoordActionCheckXCommand acquires
lock on coord action id
[ https://issues.apache.org/jira/browse/OOZIE-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256252#comment-15256252 ]
abhishek bafna commented on OOZIE-2465:
---------------------------------------
[CoordActionUpdatePushMissingDependency | https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdatePushMissingDependency.java] also uses the _actionId_.
{code}
@Override
public String getEntityKey() {
return actionId;
}
{code}
> CoordActionCheckXCommand acquires lock on coord action id
> ---------------------------------------------------------
>
> Key: OOZIE-2465
> URL: https://issues.apache.org/jira/browse/OOZIE-2465
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
>
> {code}
> @Override
> public String getEntityKey() {
> return actionId;
> }
>
> protected Void execute() throws CommandException {
> .....
> LOG.debug("Updating Coordinator actionId :" + coordAction.getId() + "status to ="
> + coordAction.getStatus());
> coordAction.setLastModifiedTime(new Date());
> updateList.add(new UpdateEntry<CoordActionQuery>(CoordActionQuery.UPDATE_COORD_ACTION_STATUS_PENDING_TIME,
> coordAction));
> ......
> {code}
> Only CoordActionCheckXCommand acquire lock on action id. All other action command acquires job id. This can cause race condition.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)