[jira] [Comment Edited] (CAMEL-11889) Kie assumes that the TCCL can load its services

["Thomas Diesler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199909#comment-16199909 ] 

Thomas Diesler edited comment on CAMEL-11889 at 10/11/17 7:29 AM:
------------------------------------------------------------------

The PR is working, but I haven't decided yet whether the correct classloader to use should be that of the Optaplaner component, the Kie API or even that of the user deployment. 

Kie caches classloaders that are associated with an arbitrary thread. This is of course highly problematic in a modular environment, where the same instance of Kie may be used by multiple modules and even multiple deployments.

Only if that what is cached is part of some static configuration (i.e. independent of deployment content) it can (reluctantly) be done at all. 
I'll revisit this at my leisure and for now agree with you, that it is not critical.


was (Author: tdiesler):
The PR is working, but I haven't decided yet whether the correct classloader to use should be that of the Optaplaner component, the Kie API or even that of the user deployment. 

Kie caches classloaders that are associated with an arbitrary thread. This is of course highly problematic in a modular environment, where the same instance of Kie may be used by multiple modules and even multiple deployments.

Only if, that what is cached is part of some static configuration (i.e. independent of deployment content) it can (reluctantly) be done at all. 
I'll revisit this at my leisure and for now agree with you, that it is not critical.

> Kie assumes that the TCCL can load its services
> -----------------------------------------------
>
>                 Key: CAMEL-11889
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11889
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-optaplanner
>            Reporter: Thomas Diesler
>            Assignee: Thomas Diesler
>             Fix For: 2.20.1, 2.21.0
>
>
> The recent update of optaplanner comes with kit-7.3.0.final, which relies on the TCCL
> https://github.com/kiegroup/droolsjbpm-knowledge/blob/7.3.0.Final/kie-api/src/main/java/org/kie/api/internal/utils/ServiceDiscoveryImpl.java#L163
> Perhaps, this can be fixed at the camel-optaplanner  component level. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)