You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ko...@apache.org on 2014/06/12 10:26:40 UTC
git commit: updated refs/heads/master to 2482da8
Repository: cloudstack
Updated Branches:
refs/heads/master 0f2c66e6c -> 2482da8cb
Fixed few coverity issues unused assignments, boxing and unboxing of values etc.
Signed-off-by: Koushik Das <ko...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/2482da8c
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/2482da8c
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/2482da8c
Branch: refs/heads/master
Commit: 2482da8cbfcf3f01b54f59149e252f5899f9c4a9
Parents: 0f2c66e
Author: Rajani Karuturi <ra...@gmail.com>
Authored: Wed Jun 11 14:36:06 2014 +0530
Committer: Koushik Das <ko...@apache.org>
Committed: Thu Jun 12 13:44:58 2014 +0530
----------------------------------------------------------------------
.../cloud/configuration/ConfigurationManagerImpl.java | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/2482da8c/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
index dbac101..f3dce48 100755
--- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -949,9 +949,7 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
}
// Check if the IP range is valid
- if (startIp != null || endIp != null) {
- checkIpRange(startIp, endIp, cidrAddress, cidrSize);
- }
+ checkIpRange(startIp, endIp, cidrAddress, cidrSize);
// Check if the IP range overlaps with the public ip
checkOverlapPublicIpRange(zoneId, startIp, endIp);
@@ -1011,7 +1009,7 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
@Override
public void doInTransactionWithoutResult(TransactionStatus status) {
// Delete private ip addresses for the pod if there are any
- List<DataCenterIpAddressVO> privateIps = _privateIpAddressDao.listByPodIdDcId(Long.valueOf(podId), pod.getDataCenterId());
+ List<DataCenterIpAddressVO> privateIps = _privateIpAddressDao.listByPodIdDcId(podId, pod.getDataCenterId());
if (!privateIps.isEmpty()) {
if (!(_privateIpAddressDao.deleteIpAddressByPod(podId))) {
throw new CloudRuntimeException("Failed to cleanup private ip addresses for pod " + podId);
@@ -1512,13 +1510,8 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
@ActionEvent(eventType = EventTypes.EVENT_ZONE_DELETE, eventDescription = "deleting zone", async = false)
public boolean deleteZone(DeleteZoneCmd cmd) {
- Long userId = CallContext.current().getCallingUserId();
final Long zoneId = cmd.getId();
- if (userId == null) {
- userId = Long.valueOf(User.UID_SYSTEM);
- }
-
// Make sure the zone exists
if (!validZone(zoneId)) {
throw new InvalidParameterValueException("A zone with ID: " + zoneId + " does not exist.");
@@ -2039,7 +2032,6 @@ public class ConfigurationManagerImpl extends ManagerBase implements Configurati
}
} else {
allowNetworkRate = true;
- ;
}
if (cmd.getNetworkRate() != null && !allowNetworkRate) {