[GitHub] [incubator-inlong] healchow commented on a change in pull request #2755: [INGLONG-2754][Agent] Add stream metric data to Prometheus and JMX

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #2755:
URL: https://github.com/apache/incubator-inlong/pull/2755#discussion_r815380357



##########
File path: inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/constant/CommonConstants.java
##########
@@ -137,5 +137,5 @@
     public static final String AGENT_NIX_OS = "nix";
     public static final String AGENT_NUX_OS = "nux";
     public static final String AGENT_COLON = ":";
-
+    

Review comment:
       Why add those blanks?

##########
File path: inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/AbstractSink.java
##########
@@ -42,4 +62,27 @@ public MessageFilter initMessageFilter(JobProfile jobConf) {
         return null;
     }
 
+    @Override
+    public void init(JobProfile jobConf) {
+

Review comment:
       Why add those empty line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org