You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2017/11/03 07:28:54 UTC

[GitHub] williaster opened a new pull request #3767: [time table] add tooltip to sparkline

williaster opened a new pull request #3767: [time table] add tooltip to sparkline
URL: https://github.com/apache/incubator-superset/pull/3767
 
 
   @mistercrunch @graceguo-supercat 
   
   This PR 
   - bumps `@data-ui/sparkline` to `0.0.47` where I [added tooltip support](https://github.com/williaster/data-ui/releases/tag/v0.0.47)
   - adds tooltips to the timeseries table sparkline that display value + date
   - opens the link for url in the timeseries table in a new tab 
   
   ![sparkline-tooltip-v0](https://user-images.githubusercontent.com/4496521/32363665-aad663da-c02d-11e7-8d58-189a2b4be747.gif)
   
   Tested sparkline functionally (see screenshot) and tested url opening in new tab functionally for group by + non-group by combos, and with new mocha test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services