You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/07/29 15:43:27 UTC
Re: svn commit: rev 2745 - trunk/subversion/clients/cmdline
rooneg@tigris.org writes:
> New Revision: 2745
>
> --- trunk/subversion/clients/cmdline/ls-cmd.c (original)
> +++ trunk/subversion/clients/cmdline/ls-cmd.c Fri Jul 26 19:04:34 2002
> @@ -33,28 +35,37 @@
>
> /*** Code. ***/
>
> +static int
> +compare_cstring_as_paths (const svn_item_t *a, const svn_item_t *b)
> +{
> + return svn_path_compare_paths_nts ((char *)a->key, (char *)b->key);
> +}
Minor nit, Garrett: a function named "compare_cstrings_as_paths"
implies to me that it takes cstrings directly. Do you mind if I
change this name to something else? (Dunno what yet, but I'll figure
out something.)
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2745 - trunk/subversion/clients/cmdline
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Mon, Jul 29, 2002 at 10:43:27AM -0500, Karl Fogel wrote:
> rooneg@tigris.org writes:
> > New Revision: 2745
> >
> > --- trunk/subversion/clients/cmdline/ls-cmd.c (original)
> > +++ trunk/subversion/clients/cmdline/ls-cmd.c Fri Jul 26 19:04:34 2002
> > @@ -33,28 +35,37 @@
> >
> > /*** Code. ***/
> >
> > +static int
> > +compare_cstring_as_paths (const svn_item_t *a, const svn_item_t *b)
> > +{
> > + return svn_path_compare_paths_nts ((char *)a->key, (char *)b->key);
> > +}
>
> Minor nit, Garrett: a function named "compare_cstrings_as_paths"
> implies to me that it takes cstrings directly. Do you mind if I
> change this name to something else? (Dunno what yet, but I'll figure
> out something.)
that's fine with me.
-garrett
--
garrett rooney Remember, any design flaw you're
rooneg@electricjellyfish.net sufficiently snide about becomes
http://electricjellyfish.net/ a feature. -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org