You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/25 11:34:45 UTC

[GitHub] [spark] wenfang6 commented on a change in pull request #26965: [SPARK-30330][SQL]Support single quotes json parsing for get_json_object and json_tuple

wenfang6 commented on a change in pull request #26965: [SPARK-30330][SQL]Support single quotes json parsing for get_json_object and json_tuple
URL: https://github.com/apache/spark/pull/26965#discussion_r361302576
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala
 ##########
 @@ -39,6 +39,13 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession {
       Row("alice", "5"))
   }
 
+  test("function get_json_object - support single quotes") {
+    val df: DataFrame = Seq(("""{'name': 'fang', 'age': 5}""")).toDF("a")
 
 Review comment:
   In this class of JsonFunctionsSuite , other tests are in the following format,
   `val df: DataFrame = tuples.toDF("key", "jstring")`
   I want to keep the same format as other tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org