You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/07/30 01:39:09 UTC

Review Request 24077: Upgrade pants to 0.0.20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/
-----------------------------------------------------------

Review request for Aurora and Bill Farner.


Repository: aurora


Description
-------

Upgrade pants to 0.0.20


Diffs
-----

  pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 

Diff: https://reviews.apache.org/r/24077/diff/


Testing
-------

./pants


Thanks,

Brian Wickman


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Brian Wickman <wi...@apache.org>.

> On July 29, 2014, 11:55 p.m., Bill Farner wrote:
> > Can you also run ./build-support/jenkins/build.sh before submitting to make sure we'll be green?

aye aye cap'n.  i ran the pants tests to completion but i'll give the build.sh a whirl too.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/#review49058
-----------------------------------------------------------


On July 29, 2014, 11:50 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24077/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 11:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade pants to 0.0.20
> 
> 
> Diffs
> -----
> 
>   pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
>   pants.ini e65e273b2505fbce41781dc3712af45dd92345ae 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 
> 
> Diff: https://reviews.apache.org/r/24077/diff/
> 
> 
> Testing
> -------
> 
> ./pants
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/#review49058
-----------------------------------------------------------

Ship it!


Can you also run ./build-support/jenkins/build.sh before submitting to make sure we'll be green?

- Bill Farner


On July 29, 2014, 11:50 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24077/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 11:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade pants to 0.0.20
> 
> 
> Diffs
> -----
> 
>   pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
>   pants.ini e65e273b2505fbce41781dc3712af45dd92345ae 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 
> 
> Diff: https://reviews.apache.org/r/24077/diff/
> 
> 
> Testing
> -------
> 
> ./pants
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Brian Wickman <wi...@apache.org>.

> On July 29, 2014, 11:54 p.m., Kevin Sweeney wrote:
> > Is there a changelog anywhere?

yes, as a matter of fact, they started publishing them just a couple releases ago:

https://pypi.python.org/pypi/pantsbuild.pants/0.0.21


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/#review49057
-----------------------------------------------------------


On July 29, 2014, 11:50 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24077/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 11:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade pants to 0.0.20
> 
> 
> Diffs
> -----
> 
>   pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
>   pants.ini e65e273b2505fbce41781dc3712af45dd92345ae 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 
> 
> Diff: https://reviews.apache.org/r/24077/diff/
> 
> 
> Testing
> -------
> 
> ./pants
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/#review49057
-----------------------------------------------------------


Is there a changelog anywhere?

- Kevin Sweeney


On July 29, 2014, 4:50 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24077/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 4:50 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade pants to 0.0.20
> 
> 
> Diffs
> -----
> 
>   pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
>   pants.ini e65e273b2505fbce41781dc3712af45dd92345ae 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 
> 
> Diff: https://reviews.apache.org/r/24077/diff/
> 
> 
> Testing
> -------
> 
> ./pants
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/
-----------------------------------------------------------

(Updated July 29, 2014, 11:50 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Update PyPI index url format which changed.


Repository: aurora


Description
-------

Upgrade pants to 0.0.20


Diffs (updated)
-----

  pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
  pants.ini e65e273b2505fbce41781dc3712af45dd92345ae 
  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 

Diff: https://reviews.apache.org/r/24077/diff/


Testing
-------

./pants


Thanks,

Brian Wickman


Re: Review Request 24077: Upgrade pants to 0.0.20

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24077/#review49048
-----------------------------------------------------------


Nevermind, I think pants 0.0.20 is actually broken.

- Brian Wickman


On July 29, 2014, 11:39 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24077/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 11:39 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade pants to 0.0.20
> 
> 
> Diffs
> -----
> 
>   pants e8c3bcf5e3cf28fb3827ead04664914f40a22616 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 26dee08bb3854b5e80e2046a2a431f41263bec46 
> 
> Diff: https://reviews.apache.org/r/24077/diff/
> 
> 
> Testing
> -------
> 
> ./pants
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>