[GitHub] [spark] hvanhovell commented on a diff in pull request #39933: [SPARK-42377][CONNECT][TESTS] Test framework for Spark Connect Scala Client

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #39933:
URL: https://github.com/apache/spark/pull/39933#discussion_r1099486517


##########
connector/connect/common/src/test/resources/query-tests/queries/function_lit.proto:
##########
@@ -0,0 +1,24 @@
+�


Review Comment:
   I would not do that for a couple of reasons:
   
   -  The interface is using proto and not json, so I strongly believe we should test that instead of a derivative. Please note that the protos are used as an input for the other test.
   - Json rendering can be less exact than we want.
   - Comparing the proto's is significantly easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org