You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/04/05 14:42:15 UTC
[GitHub] thrift pull request #1238: THRIFT-4071: collapse and remove unnecessary buil...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1238
THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI
Removed build jobs 2 and 4 as they were duplicates of 1 and 3 but on debian instead of ubuntu, this adds too little value to justify the expense of two 40 minute builds.
Added compiler plug-in option to job 6 to make sure it is tested in CI.
Combined jobs 7 and 8 because there is enough time in the build to support it.
Removed build job 9 but kept 10 because it uses debian in light of removing 2 and 4.
Removed build job 12 and 15 as they are redundant to 13 and 14 and add too little value to justify the expense.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1238
----
commit 208edb0583cf4daa673f2553317448d2f3823db3
Author: James E. King, III <ji...@simplivity.com>
Date: 2017-04-05T14:36:07Z
THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI; ensure WITH_PLUGIN is tested somewhere
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1238: THRIFT-4071: collapse and remove unnecessary build jobs ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1238
The build failure is due to a docker image rebuild because of a submit that was not against master from yesterday/today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1238: THRIFT-4071: collapse and remove unnecessary buil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1238: THRIFT-4071: collapse and remove unnecessary build jobs ...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1238
Although all builds passed, the plug-in builds were not enabled properly for autoconf and a plug-in build with cmake was missing. Pushing a fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---