You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/11 03:24:42 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
rkhachatryan opened a new pull request #19051:
URL: https://github.com/apache/flink/pull/19051
TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33053",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33053)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826750073
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
I've opened #19096 to evaluate this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33053",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29cade383a72c2b682060a1e95abbda9158aea78 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33053)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826733692
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
> the root cause of this problem is that it did not record the correct key group on logging
Yes. I mean that such a contract should also be followed in all places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826750073
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
I've opened #19096 to implement this approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan closed pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan closed pull request #19051:
URL: https://github.com/apache/flink/pull/19051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1068244407
Superseded by #19096.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1065190568
Test failures unrelated (Connection timed out when pulling dependencies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826677119
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
I think the root cause is that we don't have the correct `currentKey` during pqState#poll, if we could modify `InternalTimerServiceImpl` like below, to set the current key before calling poll:
~~~ java
private void onProcessingTime(long time) throws Exception {
// null out the timer in case the Triggerable calls registerProcessingTimeTimer()
// inside the callback.
nextTimer = null;
InternalTimer<K, N> timer;
while ((timer = processingTimeTimersQueue.peek()) != null && timer.getTimestamp() <= time) {
keyContext.setCurrentKey(timer.getKey());
processingTimeTimersQueue.poll();
triggerTarget.onProcessingTime(timer);
}
if (timer != null && nextTimer == null) {
nextTimer =
processingTimeService.registerTimer(
timer.getTimestamp(), this::onProcessingTime);
}
}
~~~
and
~~~ java
public void advanceWatermark(long time) throws Exception {
currentWatermark = time;
InternalTimer<K, N> timer;
while ((timer = eventTimeTimersQueue.peek()) != null && timer.getTimestamp() <= time) {
keyContext.setCurrentKey(timer.getKey());
eventTimeTimersQueue.poll();
triggerTarget.onEventTime(timer);
}
~~~
The test could also pass. I think this change looks better with less change and avoid to compute the key group again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826716970
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
> 1. There could be other places where eventTimeTimersQueue.poll() or remove is called. So it must be a (javadoc) contract that setCurrentKey is required before poll
As `processingTimeTimersQueue` is only used internally, I think refining the doc and description is okay .
> 2. Following the above contract, setCurrentKey should also be called on recovery (by PriorityQueueStateChangeApplier - similar to KvStateChangeApplier)
I think we don't need to set the current key on recovery, the root cause of this problem is that it did not record the correct key group on logging. And we actually could filter the keygroup out of current range in [condition check](https://github.com/apache/flink/blob/a0d31c5e0914d8e759917a72ca7b667d3db2f1d2/flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/restore/ChangelogBackendLogApplier.java#L95). However, as it did not record the corret key group, some wrong data could pass the filter then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
}, {
"hash" : "29cade383a72c2b682060a1e95abbda9158aea78",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cade383a72c2b682060a1e95abbda9158aea78",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33052)
* 29cade383a72c2b682060a1e95abbda9158aea78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064884887
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19051:
URL: https://github.com/apache/flink/pull/19051#issuecomment-1064736520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"triggerType" : "PUSH"
}, {
"hash" : "82aee14a4ac5874da8d0ab99e8253b2fb59b951a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881",
"triggerID" : "1064884887",
"triggerType" : "MANUAL"
}, {
"hash" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 82aee14a4ac5874da8d0ab99e8253b2fb59b951a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32881)
* f6f49ca5f2d7cd8ca05a51c286979a89e2f1d652 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #19051: [FLINK-26063][state/changelog] Compute keys of the removed PQ elements
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #19051:
URL: https://github.com/apache/flink/pull/19051#discussion_r826709921
##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractStateChangeLogger.java
##########
@@ -145,9 +145,17 @@ protected void log(
@Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
Ns ns)
throws IOException {
+ log(op, dataWriter, ns, keyContext.getCurrentKeyGroupIndex());
+ }
+
+ protected void log(
+ StateChangeOperation op,
+ @Nullable ThrowingConsumer<DataOutputViewStreamWrapper, IOException> dataWriter,
+ Ns ns,
+ int keyGroup)
Review comment:
Indeed, your proposal is much more simple. However, I think it has several drawbacks:
1. There could be other places where `eventTimeTimersQueue.poll()` or `remove` is called. So it must be a (javadoc) contract that `setCurrentKey` is required before `poll`
2. Following the above contract, `setCurrentKey` should also be called on recovery (by `PriorityQueueStateChangeApplier` - similar to `KvStateChangeApplier`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org