You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/11 19:39:18 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#9121: [logging] Add data_age for cached chart
graceguo-supercat opened a new pull request #9121: [logging] Add data_age for cached chart
URL: https://github.com/apache/incubator-superset/pull/9121
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Add a `data_age` in logging data when chart has is_cached flag.
### TEST PLAN
CI and manual test
### REVIEWERS
@serenajiang @etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9121: [logging] Add data_age for cached chart
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9121: [logging] Add data_age for cached chart
URL: https://github.com/apache/incubator-superset/pull/9121#discussion_r377857931
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -254,6 +255,9 @@ export function exploreJSON(
has_extra_filters:
formData.extra_filters && formData.extra_filters.length > 0,
viz_type: formData.viz_type,
+ data_age: json.is_cached
+ ? moment(new Date()).diff(moment.utc(json.cached_dttm))
+ : 0,
Review comment:
`null` might be more appropriate than `0`
```suggestion
: null,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9121: [logging]
Add data_age for cached chart
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9121: [logging] Add data_age for cached chart
URL: https://github.com/apache/incubator-superset/pull/9121#issuecomment-584841062
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=h1) Report
> Merging [#9121](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/291306392443a5a0d0e2ee0cc4a95d37c56d4589?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9121 +/- ##
=========================================
- Coverage 59.1% 59.1% -0.01%
=========================================
Files 372 372
Lines 11920 11922 +2
Branches 2917 2919 +2
=========================================
+ Hits 7045 7046 +1
- Misses 4693 4694 +1
Partials 182 182
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9121/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `43.33% <50%> (+0.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=footer). Last update [2913063...85cec4e](https://codecov.io/gh/apache/incubator-superset/pull/9121?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #9121:
[logging] Add data_age for cached chart
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #9121: [logging] Add data_age for cached chart
URL: https://github.com/apache/incubator-superset/pull/9121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian commented on a change in pull request
#9121: [logging] Add data_age for cached chart
Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #9121: [logging] Add data_age for cached chart
URL: https://github.com/apache/incubator-superset/pull/9121#discussion_r377857931
##########
File path: superset-frontend/src/chart/chartAction.js
##########
@@ -254,6 +255,9 @@ export function exploreJSON(
has_extra_filters:
formData.extra_filters && formData.extra_filters.length > 0,
viz_type: formData.viz_type,
+ data_age: json.is_cached
+ ? moment(new Date()).diff(moment.utc(json.cached_dttm))
+ : 0,
Review comment:
`null` might be more appropriate than `0`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org