You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/04/07 12:57:06 UTC
[GitHub] zeppelin pull request #2234: [ZEPPELIN-2374] update angular to 1.5.7. sortin...
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2234
[ZEPPELIN-2374] update angular to 1.5.7. sorting notes tree
### What is this PR for?
Updated angular version to 1.5.7 (added comparator to orderBy). Sorting notes tree, order:
1. folders (alphabetically)
2. notes (alphabetically)
3. Trash
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2374
### How should this be tested?
see screenshots
### Screenshots (if appropriate)
home page
before - after
navbar
before - after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2234
----
commit f511cee657dade8a98bd0f2c7f74c590caae4b60
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-07T12:24:43Z
[ZEPPELIN-2374] update angular to 1.5.7. sorting notes tree
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2234
ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2234
Nice feature @tinkoff-dwh
Tested and it works well. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2234
@tinkoff-dwh, Could you rebase for resolving conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2234
LGTM and merge to master if no further discussions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2234: [ZEPPELIN-2374] sorting notes tree
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2234: [ZEPPELIN-2374] sorting notes tree
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2234
[ZEPPELIN-2374] sorting notes tree
### What is this PR for?
Updated angular version to 1.5.7 (added comparator to orderBy). Sorting notes tree, order:
1. folders (alphabetically)
2. notes (alphabetically)
3. Trash
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2374
### How should this be tested?
see screenshots
### Screenshots (if appropriate)
home page
before - after
navbar
before - after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2234
----
commit f511cee657dade8a98bd0f2c7f74c590caae4b60
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-07T12:24:43Z
[ZEPPELIN-2374] update angular to 1.5.7. sorting notes tree
commit c6327ce9d6e2112825e5480cfdac43d368ce89c3
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-04-12T04:03:37Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2374
# Conflicts:
# zeppelin-web/bower.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2234
Let me take a look and come back
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2234: [ZEPPELIN-2374] sorting notes tree
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2234
@Leemoonsoo could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2234: [ZEPPELIN-2374] sorting notes tree
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---