You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/25 04:46:10 UTC

[GitHub] [tvm] ThomsonTan opened a new pull request #7335: Improve tensor mismatch ICHECK message

ThomsonTan opened a new pull request #7335:
URL: https://github.com/apache/tvm/pull/7335


   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   
   The current ICHECK message as below looks a little misleading for `readndim = 1`, as the space right after `read` is missing.
   
   > Check failed: ndim() == indices.size() (1 vs. 0) : Tensor dimension mismatch in readndim = 1, indices.size=0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7335: Improve tensor mismatch ICHECK message

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7335:
URL: https://github.com/apache/tvm/pull/7335#issuecomment-795602148


   Thank you @ThomsonTan !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen merged pull request #7335: Improve tensor mismatch ICHECK message

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7335:
URL: https://github.com/apache/tvm/pull/7335


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7335: Improve tensor mismatch ICHECK message

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7335:
URL: https://github.com/apache/tvm/pull/7335#issuecomment-790111644


   Thanks @ThomsonTan , can you please update the PR by fixing the lint error?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] ThomsonTan commented on pull request #7335: Improve tensor mismatch ICHECK message

Posted by GitBox <gi...@apache.org>.
ThomsonTan commented on pull request #7335:
URL: https://github.com/apache/tvm/pull/7335#issuecomment-790426884


   > Thanks @ThomsonTan , can you please update the PR by fixing the lint error?
   
   Fixed the lint error and verified it locally. Seems the latest CI run was timeout instead of failed, probably re-run the CI?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org