You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/09 15:09:52 UTC
[GitHub] [airflow] ashb commented on pull request #26252: Add updated_at to DagRun and TI tables
ashb commented on PR #26252:
URL: https://github.com/apache/airflow/pull/26252#issuecomment-1242100519
> For now the field is `nullable` because we do not have the information for existing records. Should we set it `nullable=False` and populate existing `TaskInstance.updated_at` and `DagRun.updated_at` with some default values ?
I think we have 3 options:
1. leave it as nullable
2. set it to `now()` in the migration
3. set it to `max(start_date, end_date, queued_date)` etc.
The downside to 3 is it would involve an update to _every_ row in the TI table which is generally something we want to avoid as it can make migrations take many hours for big installs.
So I think probably 1 for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org