You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Amit Sela (JIRA)" <ji...@apache.org> on 2016/10/04 15:12:21 UTC
[jira] [Created] (BEAM-703) SingletonViewFn might exhaust
defaultValue if it's serialized after used.
Amit Sela created BEAM-703:
------------------------------
Summary: SingletonViewFn might exhaust defaultValue if it's serialized after used.
Key: BEAM-703
URL: https://issues.apache.org/jira/browse/BEAM-703
Project: Beam
Issue Type: Bug
Components: sdk-java-core
Reporter: Amit Sela
Assignee: Amit Sela
Priority: Minor
In https://github.com/apache/incubator-beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/PCollectionViews.java#L267 the defaultValue is set to null to avoid decoding over and over I assume.
If the defaultValue is accessed before the the SingletonViewFn is serialized, it will exhaust the encoded value (assigned with null) while losing the transient decoded value.
It'd probably be best to simply check if defaultValue is null before decoding, so that decode will still happen just once, but the encoded data is not lost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)