[GitHub] mistercrunch commented on issue #6695: Allow empty results in Hive (from SET, eg)

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #6695: Allow empty results in Hive (from SET, eg)
URL: https://github.com/apache/incubator-superset/pull/6695#issuecomment-454595150
 
 
   My feeling is this belongs in `pyhive` (fetchall shouldn't raise if it returns no rows!), but it looks ok as is for now.
   
   By the way this is unrelated but Bogdan added this monkey patch a while back:  `superset/db_engines/hive.py` and I was wondering if it's still needed, or even if it may be causing problems. This may have been addressed in newer `pyhive` and I'd like to see if things just work when we remove this patch. Mind testing that real quick while you're in there? The test would consist of deleting the patch, and making sure that Hive logs are still captured and accessible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org