You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:18:40 UTC
[GitHub] [helix] pkuwm opened a new issue #1569: Helix Rest stoppable API serializes partitions list to a string in custom rest payloads
pkuwm opened a new issue #1569:
URL: https://github.com/apache/helix/issues/1569
### Descriptions
`CustomRestClientImpl` serializes the partitions list to a string before sending the payloads to the custom client health check Rest API. The custom client is expecting a list of partitions, but received a string. So the custom client returns an error 400. But actually the partitions are healthy. This is caused by the serialization/deserialization inconsistency between helix rest and custom client rest.
```
curl -X POST http://localhost:11933/partitionHealthStatus -d '{"partitions":["p1"]}'
```
works but Helix will actually send below that doesn't work.
```
curl -X POST http://localhost:11933/partitionHealthStatus -d '{"partitions":"[\"p1\"]"}'
```
### How to resolve
Keep the partitions list in the payload without serializing it to a string. So the custom client will get the list of partitions after deserializing the payloads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1569: Helix Rest stoppable API serializes partitions list to a string in custom rest payloads
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1569:
URL: https://github.com/apache/helix/issues/1569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org