You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 17:37:52 UTC
[GitHub] [flink] abergmeier opened a new pull request #10855:
[FLINK-15587][container] Initial container for OpenShift.
abergmeier opened a new pull request #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855
## What is the purpose of the change
OpenShift needs a minimum set of file level rights to work. Thus use best-practise for OpenShift to minimize rights so an image can run inside of OpenShift.
## Brief change log
- Created new `Dockerfile.openshift` since changes are incompatible with default variant.
- Set group rights to special group 0 (used by OpenShift container runtime).
- Set user to 1001 since user will be generated at runtime.
## Verifying this change
I have no idea how I am supposed to test this. Building the image seems quite complicated and not straight forward.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not documented
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10855:
[FLINK-15587][container] Initial container for OpenShift.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855#issuecomment-574303085
<!--
Meta data
Hash:088d6613e8dcf6be90cb83d8ec19e023830cd788 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144384170 TriggerType:PUSH TriggerID:088d6613e8dcf6be90cb83d8ec19e023830cd788
Hash:088d6613e8dcf6be90cb83d8ec19e023830cd788 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341 TriggerType:PUSH TriggerID:088d6613e8dcf6be90cb83d8ec19e023830cd788
-->
## CI report:
* 088d6613e8dcf6be90cb83d8ec19e023830cd788 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144384170) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10855:
[FLINK-15587][container] Initial container for OpenShift.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855#issuecomment-574303085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "088d6613e8dcf6be90cb83d8ec19e023830cd788",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/144384170",
"triggerID" : "088d6613e8dcf6be90cb83d8ec19e023830cd788",
"triggerType" : "PUSH"
}, {
"hash" : "088d6613e8dcf6be90cb83d8ec19e023830cd788",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341",
"triggerID" : "088d6613e8dcf6be90cb83d8ec19e023830cd788",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 088d6613e8dcf6be90cb83d8ec19e023830cd788 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144384170) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10855:
[FLINK-15587][container] Initial container for OpenShift.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855#issuecomment-574290460
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 088d6613e8dcf6be90cb83d8ec19e023830cd788 (Tue Jan 14 17:40:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15587).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10855:
[FLINK-15587][container] Initial container for OpenShift.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855#issuecomment-574303085
<!--
Meta data
Hash:088d6613e8dcf6be90cb83d8ec19e023830cd788 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:088d6613e8dcf6be90cb83d8ec19e023830cd788
-->
## CI report:
* 088d6613e8dcf6be90cb83d8ec19e023830cd788 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10855:
[FLINK-15587][container] Initial container for OpenShift.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10855: [FLINK-15587][container] Initial container for OpenShift.
URL: https://github.com/apache/flink/pull/10855#issuecomment-574303085
<!--
Meta data
Hash:088d6613e8dcf6be90cb83d8ec19e023830cd788 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144384170 TriggerType:PUSH TriggerID:088d6613e8dcf6be90cb83d8ec19e023830cd788
Hash:088d6613e8dcf6be90cb83d8ec19e023830cd788 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341 TriggerType:PUSH TriggerID:088d6613e8dcf6be90cb83d8ec19e023830cd788
-->
## CI report:
* 088d6613e8dcf6be90cb83d8ec19e023830cd788 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144384170) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4341)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services