You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/25 21:00:04 UTC
[jira] [Commented] (AVRO-2081) Compilation fails with clang
[ https://issues.apache.org/jira/browse/AVRO-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179763#comment-16179763 ]
ASF GitHub Bot commented on AVRO-2081:
--------------------------------------
GitHub user purushnayak opened a pull request:
https://github.com/apache/avro/pull/249
Compilation with clang fails due to missing codec_traits specialization
Fixed the error by adding a codec_traits specialization for
vector<bool>::const_reference.
fixes AVRO-2081
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purushnayak/avro avro-2081
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/249.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #249
----
commit 6f640667693e70447eb5b36bb86106f76865c5eb
Author: Purushotham Nayak <pn...@corelogiq.com>
Date: 2017-09-25T20:53:31Z
Compilation with clang fails due to missing codec_traits specialization
Fixed the error by adding a codec_traits specialization for
vector<bool>::const_reference.
fixes AVRO-2081
----
> Compilation fails with clang
> ----------------------------
>
> Key: AVRO-2081
> URL: https://issues.apache.org/jira/browse/AVRO-2081
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.8.2
> Environment: FreeBSD, clang++ (3.8.0)
> Reporter: Purushotham Nayak
> Priority: Minor
> Fix For: 1.9.0
>
> Attachments: AVRO-2081.patch
>
>
> Building on {{clang}} fails with the error below. This is because of the {{vector<bool>}} specialization. We need a {{codec_traits}} specialization for {{vector<bool>::const_reference}}.
> {code}
> avro/lang/c++/api/Specific.hh:321:22: error: no member named 'encode' in 'avro::codec_traits<std::__1::__bit_const_reference<std::__1::vector<bool, std::__1::allocator<bool> > > >'
> codec_traits<T>::encode(e, t);
> ~~~~~~~~~~~~~~~~~^
> avro/lang/c++/api/Specific.hh:235:23: note: in instantiation of function template specialization 'avro::encode<std::__1::__bit_const_reference<std::__1::vector<bool, std::__1::allocator<bool> > > >' requested here
> avro::encode(e, *it);
> ^
> avro/lang/c++/api/Specific.hh:321:22: note: in instantiation of member function 'avro::codec_traits<std::__1::vector<bool, std::__1::allocator<bool> > >::encode' requested here
> codec_traits<T>::encode(e, t);
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)