You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Emmanuel Lécharny <el...@gmail.com> on 2018/03/03 19:47:16 UTC
Errors when buuilding MINA 2.0 branch
Hi,
I'm trying to build MINA 2.0 with the latest changes made by Jonathan,
and I get some random error in a test :
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
11.378 s <<< FAILURE! - in org.apache.mina.example.echoserver.ConnectorTest
[ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
Time elapsed: 11.079 s <<< FAILURE!
java.lang.AssertionError: expected:<160> but was:<32>
at
org.apache.mina.example.echoserver.ConnectorTest.waitForResponse(ConnectorTest.java:222)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector0(ConnectorTest.java:192)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:141)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:103)
at
org.apache.mina.example.echoserver.ConnectorTest.testTCPWithSSL(ConnectorTest.java:90)
or
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
11.528 s <<< FAILURE! - in org.apache.mina.example.echoserver.ConnectorTest
[ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
Time elapsed: 11.226 s <<< FAILURE!
java.lang.AssertionError: expected:<160> but was:<0>
at
org.apache.mina.example.echoserver.ConnectorTest.waitForResponse(ConnectorTest.java:222)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector0(ConnectorTest.java:192)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:141)
at
org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:106)
at
org.apache.mina.example.echoserver.ConnectorTest.testTCPWithSSL(ConnectorTest.java:90)
It's pretty random.
I'm going to investigate what's going on, but that was one of the reason
I wasn't able to cut the release last december...
If anyone has an idea...
--
Emmanuel Lecharny
Symas.com
directory.apache.org
Re: Errors when buuilding MINA 2.0 branch
Posted by Christoph John <ch...@macd.com>.
https://github.com/apache/mina/pull/13
On 03/03/18 22:54, Christoph John wrote:
> BTW, is there a reason why **/Abstract* and **/*RegressionTest* are excluded fromthe surefire
> plugin? This leads to some tests not executed, in my case specifically the tests for
> AbstractIoService.
>
> Chris.
>
> On 03/03/18 22:41, Christoph John wrote:
>> Hi,
>>
>> I'll open a PR in due course for the tests for DIRMINA-1076/1077. But I don't thinkthat the
>> release needs to wait for this.
>>
>> Thanks and cheers,
>> Chris.
>>
>> On 03/03/18 21:32, Jonathan Valliere wrote:
>>> No, I don’t feel like fixing it. It really duplicates the efforts of some
>>> other existing unit tests. Specifically the ones referenced in
>>> DIRMINA-1076/1077
>>>
>>> Please revert one of the AprIoProcessor commits. Otherwise, I don’t have
>>> anything else.
>>>
>>> On Sat, Mar 3, 2018 at 3:23 PM, Emmanuel Lécharny <el...@gmail.com>
>>> wrote:
>>>
>>>>
>>>> Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
>>>>> Emmanuel,
>>>>>
>>>>> IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
>>>>> concurrency problems in how it waits on the handler and manipulates the
>>>>> buffer independent of whatever the IoProcessor is doing. I would expect
>>>> it
>>>>> to fail randomly. I don’t think that these failures indicate anything
>>>>> wrong with Mina.
>>>>
>>>> Ok. I'll @Ignore the test then, unless you want to fix it.
>>>>
>>>>
>>>> Is there anything else we want to get fixed before I start cuting 2.0.17 ?
>>>>
>>>>
>>>> --
>>>> Emmanuel Lecharny
>>>>
>>>> Symas.com
>>>> directory.apache.org
>>>>
>>>>
>>
>
--
Christoph John
Development & Support
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Errors when buuilding MINA 2.0 branch
Posted by Christoph John <ch...@macd.com>.
OK, thanks. I've re-enabled them in my PR.
Cheers,
Chris.
On 03/03/18 23:26, Emmanuel Lécharny wrote:
>
> Le 03/03/2018 à 22:54, Christoph John a écrit :
>> BTW, is there a reason why **/Abstract* and **/*RegressionTest* are
>> excluded fromthe surefire plugin? This leads to some tests not executed,
>> in my case specifically the tests for AbstractIoService.
> Those excludes have been present since almost the very beginning (Nov
> 4th, 2005)...
> (http://svn.apache.org/viewvc/directory/network/trunk/pom.xml?r1=330747&r2=344367&pathrev=359811&diff_format=h)
>
> I have no idea why those tests are excluded.
>
--
Christoph John
Development & Support
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Errors when buuilding MINA 2.0 branch
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 03/03/2018 à 22:54, Christoph John a écrit :
> BTW, is there a reason why **/Abstract* and **/*RegressionTest* are
> excluded fromthe surefire plugin? This leads to some tests not executed,
> in my case specifically the tests for AbstractIoService.
Those excludes have been present since almost the very beginning (Nov
4th, 2005)...
(http://svn.apache.org/viewvc/directory/network/trunk/pom.xml?r1=330747&r2=344367&pathrev=359811&diff_format=h)
I have no idea why those tests are excluded.
--
Emmanuel Lecharny
Symas.com
directory.apache.org
Re: Errors when buuilding MINA 2.0 branch
Posted by Christoph John <ch...@macd.com>.
BTW, is there a reason why **/Abstract* and **/*RegressionTest* are excluded fromthe surefire
plugin? This leads to some tests not executed, in my case specifically the tests for AbstractIoService.
Chris.
On 03/03/18 22:41, Christoph John wrote:
> Hi,
>
> I'll open a PR in due course for the tests for DIRMINA-1076/1077. But I don't thinkthat the
> release needs to wait for this.
>
> Thanks and cheers,
> Chris.
>
> On 03/03/18 21:32, Jonathan Valliere wrote:
>> No, I don’t feel like fixing it. It really duplicates the efforts of some
>> other existing unit tests. Specifically the ones referenced in
>> DIRMINA-1076/1077
>>
>> Please revert one of the AprIoProcessor commits. Otherwise, I don’t have
>> anything else.
>>
>> On Sat, Mar 3, 2018 at 3:23 PM, Emmanuel Lécharny <el...@gmail.com>
>> wrote:
>>
>>>
>>> Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
>>>> Emmanuel,
>>>>
>>>> IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
>>>> concurrency problems in how it waits on the handler and manipulates the
>>>> buffer independent of whatever the IoProcessor is doing. I would expect
>>> it
>>>> to fail randomly. I don’t think that these failures indicate anything
>>>> wrong with Mina.
>>>
>>> Ok. I'll @Ignore the test then, unless you want to fix it.
>>>
>>>
>>> Is there anything else we want to get fixed before I start cuting 2.0.17 ?
>>>
>>>
>>> --
>>> Emmanuel Lecharny
>>>
>>> Symas.com
>>> directory.apache.org
>>>
>>>
>
--
Christoph John
Development & Support
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Errors when buuilding MINA 2.0 branch
Posted by Christoph John <ch...@macd.com>.
Hi,
I'll open a PR in due course for the tests for DIRMINA-1076/1077. But I don't thinkthat the release
needs to wait for this.
Thanks and cheers,
Chris.
On 03/03/18 21:32, Jonathan Valliere wrote:
> No, I don’t feel like fixing it. It really duplicates the efforts of some
> other existing unit tests. Specifically the ones referenced in
> DIRMINA-1076/1077
>
> Please revert one of the AprIoProcessor commits. Otherwise, I don’t have
> anything else.
>
> On Sat, Mar 3, 2018 at 3:23 PM, Emmanuel Lécharny <el...@gmail.com>
> wrote:
>
>>
>> Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
>>> Emmanuel,
>>>
>>> IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
>>> concurrency problems in how it waits on the handler and manipulates the
>>> buffer independent of whatever the IoProcessor is doing. I would expect
>> it
>>> to fail randomly. I don’t think that these failures indicate anything
>>> wrong with Mina.
>>
>> Ok. I'll @Ignore the test then, unless you want to fix it.
>>
>>
>> Is there anything else we want to get fixed before I start cuting 2.0.17 ?
>>
>>
>> --
>> Emmanuel Lecharny
>>
>> Symas.com
>> directory.apache.org
>>
>>
--
Christoph John
Development & Support
T +49 241 557080-28
christoph.john@macd.com
MACD GmbH
Oppenhoffallee 103
D-52066 Aachen
www.macd.com
Amtsgericht Aachen: HRB 8151
Ust.-Id: DE 813021663
Geschäftsführer: George Macdonald
Re: Errors when buuilding MINA 2.0 branch
Posted by Jonathan Valliere <jo...@emoten.com>.
No, I don’t feel like fixing it. It really duplicates the efforts of some
other existing unit tests. Specifically the ones referenced in
DIRMINA-1076/1077
Please revert one of the AprIoProcessor commits. Otherwise, I don’t have
anything else.
On Sat, Mar 3, 2018 at 3:23 PM, Emmanuel Lécharny <el...@gmail.com>
wrote:
>
>
> Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
> > Emmanuel,
> >
> > IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
> > concurrency problems in how it waits on the handler and manipulates the
> > buffer independent of whatever the IoProcessor is doing. I would expect
> it
> > to fail randomly. I don’t think that these failures indicate anything
> > wrong with Mina.
>
>
> Ok. I'll @Ignore the test then, unless you want to fix it.
>
>
> Is there anything else we want to get fixed before I start cuting 2.0.17 ?
>
>
> --
> Emmanuel Lecharny
>
> Symas.com
> directory.apache.org
>
>
Re: Errors when buuilding MINA 2.0 branch
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 03/03/2018 à 21:15, Jonathan Valliere a écrit :
> Emmanuel,
>
> IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
> concurrency problems in how it waits on the handler and manipulates the
> buffer independent of whatever the IoProcessor is doing. I would expect it
> to fail randomly. I don’t think that these failures indicate anything
> wrong with Mina.
Ok. I'll @Ignore the test then, unless you want to fix it.
Is there anything else we want to get fixed before I start cuting 2.0.17 ?
--
Emmanuel Lecharny
Symas.com
directory.apache.org
Re: Errors when buuilding MINA 2.0 branch
Posted by Jonathan Valliere <jo...@apache.org>.
Emmanuel,
IMHO ConnectorTest, from a quick glance, suffers from some pretty bad
concurrency problems in how it waits on the handler and manipulates the
buffer independent of whatever the IoProcessor is doing. I would expect it
to fail randomly. I don’t think that these failures indicate anything
wrong with Mina.
On Sat, Mar 3, 2018 at 2:48 PM, Jonathan Valliere <jo...@apache.org>
wrote:
> I’m fixing AprIo right now
>
> On Sat, Mar 3, 2018 at 2:47 PM Emmanuel Lécharny <el...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I'm trying to build MINA 2.0 with the latest changes made by Jonathan,
>> and I get some random error in a test :
>>
>> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 11.378 s <<< FAILURE! - in org.apache.mina.example.
>> echoserver.ConnectorTest
>> [ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
>> Time elapsed: 11.079 s <<< FAILURE!
>> java.lang.AssertionError: expected:<160> but was:<32>
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> waitForResponse(ConnectorTest.java:222)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector0(ConnectorTest.java:192)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector(ConnectorTest.java:141)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector(ConnectorTest.java:103)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testTCPWithSSL(ConnectorTest.java:90)
>>
>>
>>
>> or
>>
>>
>> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 11.528 s <<< FAILURE! - in org.apache.mina.example.
>> echoserver.ConnectorTest
>> [ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
>> Time elapsed: 11.226 s <<< FAILURE!
>> java.lang.AssertionError: expected:<160> but was:<0>
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> waitForResponse(ConnectorTest.java:222)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector0(ConnectorTest.java:192)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector(ConnectorTest.java:141)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testConnector(ConnectorTest.java:106)
>> at
>> org.apache.mina.example.echoserver.ConnectorTest.
>> testTCPWithSSL(ConnectorTest.java:90)
>>
>>
>>
>> It's pretty random.
>>
>>
>> I'm going to investigate what's going on, but that was one of the reason
>> I wasn't able to cut the release last december...
>>
>> If anyone has an idea...
>>
>>
>> --
>> Emmanuel Lecharny
>>
>> Symas.com
>> directory.apache.org
>>
>>
Re: Errors when buuilding MINA 2.0 branch
Posted by Jonathan Valliere <jo...@apache.org>.
I’m fixing AprIo right now
On Sat, Mar 3, 2018 at 2:47 PM Emmanuel Lécharny <el...@gmail.com>
wrote:
> Hi,
>
> I'm trying to build MINA 2.0 with the latest changes made by Jonathan,
> and I get some random error in a test :
>
> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 11.378 s <<< FAILURE! - in org.apache.mina.example.echoserver.ConnectorTest
> [ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
> Time elapsed: 11.079 s <<< FAILURE!
> java.lang.AssertionError: expected:<160> but was:<32>
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.waitForResponse(ConnectorTest.java:222)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector0(ConnectorTest.java:192)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:141)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:103)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testTCPWithSSL(ConnectorTest.java:90)
>
>
>
> or
>
>
> [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 11.528 s <<< FAILURE! - in org.apache.mina.example.echoserver.ConnectorTest
> [ERROR] testTCPWithSSL(org.apache.mina.example.echoserver.ConnectorTest)
> Time elapsed: 11.226 s <<< FAILURE!
> java.lang.AssertionError: expected:<160> but was:<0>
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.waitForResponse(ConnectorTest.java:222)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector0(ConnectorTest.java:192)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:141)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testConnector(ConnectorTest.java:106)
> at
>
> org.apache.mina.example.echoserver.ConnectorTest.testTCPWithSSL(ConnectorTest.java:90)
>
>
>
> It's pretty random.
>
>
> I'm going to investigate what's going on, but that was one of the reason
> I wasn't able to cut the release last december...
>
> If anyone has an idea...
>
>
> --
> Emmanuel Lecharny
>
> Symas.com
> directory.apache.org
>
>