[GitHub] [nifi] markap14 commented on a change in pull request #3894: NIFI-6884 - Native library loading fixed/improved

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #3894: NIFI-6884 - Native library loading fixed/improved
URL: https://github.com/apache/nifi/pull/3894#discussion_r349306445
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarClassLoader.java
 ##########
 @@ -205,26 +216,41 @@ private void updateClasspath(File root) throws IOException {
     }
 
     @Override
-    protected String findLibrary(final String libname) {
+    public String findLibrary(String libname) {
 
 Review comment:
   Is there a reason here to override the method just to call the superclass definition, instead of just removing the method from NarClassLoader?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services