[superset] branch john-bodley--chore-cleanup-read-csv created (now 4ed0598)

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a change to branch john-bodley--chore-cleanup-read-csv
in repository https://gitbox.apache.org/repos/asf/superset.git.


      at 4ed0598  chore(csv): Cleanup Pandas read_csv logic

This branch includes the following new commits:

     new 4ed0598  chore(csv): Cleanup Pandas read_csv logic

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: chore(csv): Cleanup Pandas read_csv logic

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--chore-cleanup-read-csv
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 4ed0598134916103e15e7ee5a974c9d105d68215
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Tue Apr 20 07:04:59 2021 +1200

    chore(csv): Cleanup Pandas read_csv logic
---
 superset/db_engine_specs/base.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset/db_engine_specs/base.py b/superset/db_engine_specs/base.py
index 5cdb2a0..a793341 100644
--- a/superset/db_engine_specs/base.py
+++ b/superset/db_engine_specs/base.py
@@ -621,9 +621,7 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
         """
         kwargs["encoding"] = "utf-8"
         kwargs["iterator"] = True
-        chunks = pd.read_csv(**kwargs)
-        df = pd.concat(chunk for chunk in chunks)
-        return df
+        return pd.read_csv(**kwargs)
 
     @classmethod
     def df_to_sql(cls, df: pd.DataFrame, **kwargs: Any) -> None: