You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2007/08/27 19:55:31 UTC
[jira] Created: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
---------------------------------------------------------------------
Key: LUCENENET-96
URL: https://issues.apache.org/jira/browse/LUCENENET-96
Project: Lucene.Net
Issue Type: Bug
Reporter: Digy
Priority: Minor
After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524289 ]
Digy commented on LUCENENET-96:
-------------------------------
There is an issue discussing the same bug in java.
https://issues.apache.org/jira/browse/LUCENE-812.
Solution: package-private constructor and "setLockDir()"
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-96:
--------------------------
Attachment: TestLockFactory.patch
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524206 ]
Digy commented on LUCENENET-96:
-------------------------------
Hi George,
When I looked at the java code, i saw that NativeFSLockFactory and SimpleFSLockFactory have parameterless
constructors and setLockDir methods, only for the use of FSDirector.
These methods are not available in the Lucene.net.
-------------------------------------
/**
* Create a SimpleFSLockFactory instance, with null (unset)
* lock directory. This is package-private and is only
* used by FSDirectory when creating this LockFactory via
* the System property
* org.apache.lucene.store.FSDirectoryLockFactoryClass.
*/
SimpleFSLockFactory() throws IOException {
this((File) null);
}
/**
* Set the lock directory. This is package-private and is
* only used externally by FSDirectory when creating this
* LockFactory via the System property
* org.apache.lucene.store.FSDirectoryLockFactoryClass.
*/
void setLockDir(File lockDir) throws IOException {
this.lockDir = lockDir;
}
-------------------------------------
To be able to pass the Nunit test of "Store.TestLockFactory.TestLockClassProperty":
As in Java Version,
a) These methods can be added to NativeFSLockFactory and SimpleFSLockFactory
b) FSDirectory.Init can be modified by inserting the translated java-codes (which are also not available in
Lucene.Net)
if (lockFactory instanceof NativeFSLockFactory) {
((NativeFSLockFactory) lockFactory).setLockDir(path);
} else if (lockFactory instanceof SimpleFSLockFactory) {
((SimpleFSLockFactory) lockFactory).setLockDir(path);
}
after the creation of the XXXXFSLockFactory class ( c.newInstance() ).
But I think, patches I posted previously are more generic and this also doesn't mean divergence from
java, since the existing codes already differ from it.
DIGY
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-96:
--------------------------
Attachment: (was: FSDirectory.patch)
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-96:
--------------------------
Attachment: SupportClass.patch
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526706 ]
Digy commented on LUCENENET-96:
-------------------------------
Hi George,
1- I removed the unnecessary patch.
2- I applied the others to a fresh copy of Lucene.NET and it worked for me.
DIGY
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-96:
--------------------------
Attachment: FSDirectory.patch
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush resolved LUCENENET-96.
------------------------------------
Resolution: Fixed
Applied patch and commited.
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526625 ]
George Aroush commented on LUCENENET-96:
----------------------------------------
Hi DIGY,
This patch isn't working for me. After applying it, when I try to run TestLockFactory.TestLockClassProperty() it will hang (CPU at %100). Can you please revalidate and maybe send me a new patch? I used the patch from "Patch v2.rar" to overwrite the other patches attached to this issue.
Regards,
-- George
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-96:
--------------------------
Attachment: Patch v2.rar
I will attach an alternative patch that is closer to Lucene-Java as I commented previously.
SupportClass.patch and TestLockFactory.patch are still valid.
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Priority: Minor
> Attachments: FSDirectory.patch, Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush reassigned LUCENENET-96:
--------------------------------------
Assignee: George Aroush
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LUCENENET-96) NUnit test for
Lucene.Net.Store.TestLockFactory.TestLockClassProperty
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Aroush closed LUCENENET-96.
----------------------------------
> NUnit test for Lucene.Net.Store.TestLockFactory.TestLockClassProperty
> ---------------------------------------------------------------------
>
> Key: LUCENENET-96
> URL: https://issues.apache.org/jira/browse/LUCENENET-96
> Project: Lucene.Net
> Issue Type: Bug
> Reporter: Digy
> Assignee: George Aroush
> Priority: Minor
> Attachments: Patch v2.rar, SupportClass.patch, TestLockFactory.patch
>
>
> After java2C# translation, i added "Set" method to SupportClass.AppSettings and modified the "get" methods.
> Since NativeFSLockFactory does not have parameterless constructor, i modified FSDirectory to be able to create an instance of NativeFSLockFactory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.