You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/06/04 16:45:12 UTC
[Bug 55056] New: wasted work in Data.append()
https://issues.apache.org/bugzilla/show_bug.cgi?id=55056
Bug ID: 55056
Summary: wasted work in Data.append()
Product: JMeter
Version: 2.9
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: nistor1@illinois.edu
Created attachment 30386
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30386&action=edit
patch
The problem appears in version 2.9 and in revision 1489451. I
attached a one-line patch that fixes it.
In method "Data.append", the loop over "dHeaders" should break
immediately after "valid" is set to "false". All the iterations after
"valid" is set to "false" do not perform any useful work, at best they
just set "valid" again to "false".
Method "include" in class "ClassFilter" has a similar loop (over
"pkgs"), and this loop breaks immediately after "inc" is set to
"true", just like in the proposed patch. Other methods (e.g.,
"Copy.keepOnlyAncestors", "JMeterThread.getSampleListeners",
"HTTPSamplerBase.getSendParameterValuesAsPostBody",
"LogFilter.incFile") also have similar loops with similar breaks, just
like in the proposed patch.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55056] wasted work in Data.append()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55056
Adrian Nistor <ni...@illinois.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55056] wasted work in Data.append()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55056
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Sebb <se...@apache.org> ---
Well spotted; thanks for the patch!
URL: http://svn.apache.org/r1489490
Log:
wasted work in Data.append()
Bugzilla Id: 55056
Modified:
jmeter/trunk/src/jorphan/org/apache/jorphan/collections/Data.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.