[GitHub] [geode-native] davebarnes97 opened pull request #447: Feature/geode 4728 region shortcut

["davebarnes97 (GitHub)" <gi...@apache.org>]

[ Full content available at: https://github.com/apache/geode-native/pull/447 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on issue #447: Feature/geode 4728 region shortcut

["echobravopapa (GitHub)" <gi...@apache.org>]

@davebarnes97 @pdxcodemonkey we need to hold the line on Commit message format.... 

[ Full content available at: https://github.com/apache/geode-native/pull/447 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey commented on issue #447: Feature/geode 4728 region shortcut

["pdxcodemonkey (GitHub)" <gi...@apache.org>]

Indeed, my apologies.  Dave, when we merge into develop, the title of the commit should start with the Jira ticket # and ":", like the description does in your commit.  the title should have just a few words, then the description should capture the detail of all the commits squashed and merged, usually as a bulleted list using * or -.  The GitHub UI messes this up for you when you merge, so you always have to edit before hitting the merge button.  This is perhaps my least favorite feature of GitHub PRs.

[ Full content available at: https://github.com/apache/geode-native/pull/447 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] davebarnes97 closed pull request #447: Feature/geode 4728 region shortcut

["davebarnes97 (GitHub)" <gi...@apache.org>]

[ pull request closed by davebarnes97 ]

[ Full content available at: https://github.com/apache/geode-native/pull/447 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org