You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by josephw <gi...@git.apache.org> on 2015/06/11 17:34:56 UTC
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
GitHub user josephw opened a pull request:
https://github.com/apache/maven/pull/51
MNG-5297: Mark <prerequisites> as deprecated.
MNG-4840 indicates that the Enforcer plugin should be
preferred to <prerequisites>. Indicate that in the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephw/maven MNG-5297-mark-prerequisites-maven-as-deprecated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit c307e4ec0cb9997b20fc4aa67eefa836986fc484
Author: Joseph Walton <jo...@kafsemo.org>
Date: 2015-06-11T15:32:38Z
MNG-5297: Mark <prerequisites> as deprecated.
MNG-4840 indicates that the Enforcer plugin should be
preferred to <prerequisites>. Indicate that in the documentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138297887
I'm reasonably sure it's never been used for build-time enforcement. Anything to make it clear that the enforcer is for build-time and the prerequisite element is for runtime is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-112843851
@kwin , @mosabua: thanks. I've rewritten it to reflect that distinction, that it's only deprecated for compile-time enforcement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138302328
Even if it wasn't the intended use, way back in Maven 2:
<prerequisites>
<maven>4</maven>
</prerequisites>
would give:
$ mvn2 validate
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Unable to build project '/tmp/pom.xml; it requires Maven version 4
The current language in the documentation is still:
The minimum version of Maven required to build the project.
so I think this PR clarifies the current intent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138286028
@kwin, @mosabua - is this current form acceptable as a fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by mosabua <gi...@git.apache.org>.
Github user mosabua commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-112198560
Enforcer plugin is for build time enforcement. Prerequisite is build time as well as plugin runtime requirement. As such it should not be deprecated. Documentation update would however be useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by josephw <gi...@git.apache.org>.
Github user josephw commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138297080
@jvanzyl although the original change was unconditional deprecation, I changed it after comments so the current language in the patch is intended to reflect that distinction:
> For a plugin project, the minimum version of Maven required to use
the resulting plugin.
> For specifying the minimum version of Maven required to build a project, this element is <b>deprecated</b>.
My intention here is to make clear that it's deprecated for *some* purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138295450
No. The enforcer plugin is for build-time enforcement. The <prerequisite/> element is for runtime enforcement. We certainly don't want to have to inspect the any plugin configuration elements to help Maven know that the current environment won't run the plugin. Also, if we ever get around to having the build vs consumption POM this information would not be available at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by kwin <gi...@git.apache.org>.
Github user kwin commented on a diff in the pull request:
https://github.com/apache/maven/pull/51#discussion_r32460741
--- Diff: maven-model/src/main/mdo/maven.mdo ---
@@ -3459,6 +3459,7 @@
<type>String</type>
<defaultValue>2.0</defaultValue>
<description><![CDATA[
+ <b>Deprecated</b>. Use the Maven Enforcer Plugin's <a href="https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html"><code>requireMavenVersion</code></a> rule instead.<br>
--- End diff --
This <prerequisites> is still supported for Maven Plugins (https://issues.apache.org/jira/browse/MNG-5501?focusedCommentId=14419813&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14419813), therefore rather than deprecating that I would add a hint, that this should only be used for packaging "plugin".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: MNG-5297: Mark as deprecated.
Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/51#issuecomment-138307685
Fair enough, I cannot remember that far back :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org