You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/27 08:54:01 UTC
[GitHub] [airflow] tooptoop4 opened a new pull request #6922: [AIRFLOW-5385]
spark hook does not work on spark 2.3/2.4
tooptoop4 opened a new pull request #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6922: [AIRFLOW-5385] spark
hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 84.71% 84.43% -0.28%
==========================================
Files 679 680 +1
Lines 38508 38565 +57
==========================================
- Hits 32622 32563 -59
- Misses 5886 6002 +116
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `84.55% <92.85%> (+1.83%)` | :arrow_up: |
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `91.3% <0%> (-8.7%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `71.69% <0%> (-3.04%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <0%> (-2.91%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...137faf9](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 84.71% 84.43% -0.28%
==========================================
Files 679 680 +1
Lines 38508 38565 +57
==========================================
- Hits 32622 32563 -59
- Misses 5886 6002 +116
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `84.55% <92.85%> (+1.83%)` | :arrow_up: |
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `91.3% <0%> (-8.7%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `71.69% <0%> (-3.04%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <0%> (-2.91%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...137faf9](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#discussion_r361842287
##########
File path: tests/contrib/hooks/test_spark_submit_hook.py
##########
@@ -166,6 +166,38 @@ def test_build_spark_submit_command(self):
]
self.assertEqual(expected_build_cmd, cmd)
+ def test_build_track_driver_status_command(self):
+ # note this function is only relevant for spark setup matching below condition
+ # 'spark://' in self._connection['master'] and self._connection['deploy_mode'] == 'cluster'
+
+ # Given
+ hook_spark_standalone_cluster = SparkSubmitHook(
+ conn_id='spark_standalone_cluster')
+ hook_spark_standalone_cluster._driver_id = 'driver-20171128111416-0001'
+ hook_spark_yarn_cluster = SparkSubmitHook(
+ conn_id='spark_yarn_cluster')
+ hook_spark_yarn_cluster._driver_id = 'driver-20171128111417-0001'
+
+ # When
+ build_track_driver_status_spark_standalone_cluster = \
+ hook_spark_standalone_cluster._build_track_driver_status_command()
+ build_track_driver_status_spark_yarn_cluster = \
+ hook_spark_yarn_cluster._build_track_driver_status_command()
+
+ # Then
+ expected_build_track_driver_status_spark_standalone_cluster = [
+ '/usr/bin/curl',
+ '--max-time',
+ '30',
+ 'http://spark-standalone-master:6066/v1/submissions/status/driver-20171128111416-0001']
+ expected_build_track_driver_status_spark_yarn_cluster = [
+ 'spark-submit', '--master', 'yarn://yarn-master', '--status', 'driver-20171128111417-0001']
+
+ self.assertListEqual(expected_build_track_driver_status_spark_standalone_cluster,
Review comment:
Since we are switching to pytest, it would be great to use the standard asserts from python.
Pytest does all the heavy lifting and rewrites the assertions so `assert a == b` works very well also for iterables (and provides useful comparison report).
https://docs.pytest.org/en/latest/example/reportingdemo.html#tbreportdemo
```
self = <failure_demo.TestSpecialisedExplanations object at 0xdeadbeef>
def test_eq_list(self):
> assert [0, 1, 2] == [0, 1, 3]
E assert [0, 1, 2] == [0, 1, 3]
E At index 2 diff: 2 != 3
E Use -v to get the full diff
failure_demo.py:64: AssertionError
```
We have switched now to use the standard python asserts wherever possible. See https://github.com/apache/airflow/blob/master/TESTING.rst#writing-unit-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 removed a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
tooptoop4 removed a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569449184
@potiuk _driver_id is not accepted in __init__ (https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/airflow/contrib/hooks/spark_submit_hook.py#L158) , how to inject it into https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/airflow/contrib/hooks/spark_submit_hook.py#L325-L334 from https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/tests/contrib/hooks/test_spark_submit_hook.py ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6922: [AIRFLOW-5385] spark
hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569236323
Can we please add some tests with mocking for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 679 679
Lines 38508 38517 +9
=========================================
- Hits 32622 32516 -106
- Misses 5886 6001 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.96%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+1.15%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on a change in pull request #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on a change in pull request #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#discussion_r362179929
##########
File path: tests/contrib/hooks/test_spark_submit_hook.py
##########
@@ -166,6 +166,38 @@ def test_build_spark_submit_command(self):
]
self.assertEqual(expected_build_cmd, cmd)
+ def test_build_track_driver_status_command(self):
+ # note this function is only relevant for spark setup matching below condition
+ # 'spark://' in self._connection['master'] and self._connection['deploy_mode'] == 'cluster'
+
+ # Given
+ hook_spark_standalone_cluster = SparkSubmitHook(
+ conn_id='spark_standalone_cluster')
+ hook_spark_standalone_cluster._driver_id = 'driver-20171128111416-0001'
+ hook_spark_yarn_cluster = SparkSubmitHook(
+ conn_id='spark_yarn_cluster')
+ hook_spark_yarn_cluster._driver_id = 'driver-20171128111417-0001'
+
+ # When
+ build_track_driver_status_spark_standalone_cluster = \
+ hook_spark_standalone_cluster._build_track_driver_status_command()
+ build_track_driver_status_spark_yarn_cluster = \
+ hook_spark_yarn_cluster._build_track_driver_status_command()
+
+ # Then
+ expected_build_track_driver_status_spark_standalone_cluster = [
+ '/usr/bin/curl',
+ '--max-time',
+ '30',
+ 'http://spark-standalone-master:6066/v1/submissions/status/driver-20171128111416-0001']
+ expected_build_track_driver_status_spark_yarn_cluster = [
+ 'spark-submit', '--master', 'yarn://yarn-master', '--status', 'driver-20171128111417-0001']
+
+ self.assertListEqual(expected_build_track_driver_status_spark_standalone_cluster,
Review comment:
@potiuk see https://github.com/apache/airflow/pull/6976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a4b4446c6361af3210f29ddf39fcffb04e858f84?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 84.71% 84.43% -0.28%
==========================================
Files 679 680 +1
Lines 38508 38565 +57
==========================================
- Hits 32622 32563 -59
- Misses 5886 6002 +116
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `84.55% <92.85%> (+1.83%)` | :arrow_up: |
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `91.3% <0%> (-8.7%)` | :arrow_down: |
| [airflow/utils/cli.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9jbGkucHk=) | `71.69% <0%> (-3.04%)` | :arrow_down: |
| [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `94.57% <0%> (-2.91%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [a4b4446...137faf9](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 closed pull request #6922: [AIRFLOW-5385] spark
hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
tooptoop4 closed pull request #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **decrease** coverage by `0.3%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 84.72% 84.41% -0.31%
==========================================
Files 679 679
Lines 38505 38517 +12
==========================================
- Hits 32623 32516 -107
- Misses 5882 6001 +119
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.74%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <0%> (ø)` | :arrow_up: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `96.05% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [947fb64...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6922:
[AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569241028
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=h1) Report
> Merging [#6922](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr&el=desc) will **decrease** coverage by `0.3%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6922 +/- ##
==========================================
- Coverage 84.72% 84.41% -0.31%
==========================================
Files 679 679
Lines 38505 38517 +12
==========================================
- Hits 32623 32516 -107
- Misses 5882 6001 +119
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `79.76% <18.18%> (-2.74%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <0%> (ø)` | :arrow_up: |
| [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/6922/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `96.05% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=footer). Last update [947fb64...9079e44](https://codecov.io/gh/apache/airflow/pull/6922?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6922: [AIRFLOW-5385] spark
hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569452966
@potiuk test added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6922: [AIRFLOW-5385] spark
hook does not work on spark 2.3/2.4
Posted by GitBox <gi...@apache.org>.
tooptoop4 commented on issue #6922: [AIRFLOW-5385] spark hook does not work on spark 2.3/2.4
URL: https://github.com/apache/airflow/pull/6922#issuecomment-569449184
@potiuk _driver_id is not accepted in __init__ (https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/airflow/contrib/hooks/spark_submit_hook.py#L158) , how to inject it into https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/airflow/contrib/hooks/spark_submit_hook.py#L325-L334 from https://github.com/apache/airflow/blob/9079e44cc134a2e71879c9e924ee9f827ea6d30a/tests/contrib/hooks/test_spark_submit_hook.py ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services