[jira] Commented: (MECLIPSE-363) eclipse:to-maven crashes if any plugin JAR lacks a Bundle-SymbolicName field in its manifest

["Markku Saarela (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MECLIPSE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=216684#action_216684 ] 

Markku Saarela commented on MECLIPSE-363:
-----------------------------------------

TestNG plugin version 5.9.0.2 has minimal manifest:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.0
Created-By: 1.6.0_01-b06 (Sun Microsystems Inc.)

As workaround i removed this manifest but i'd like to get this patch also included to next release.

> eclipse:to-maven crashes if any plugin JAR lacks a Bundle-SymbolicName field in its manifest
> --------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-363
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-363
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>         Environment: Eclipse 3.3, Linux, Eclipse SODA DeviceKit and SAT SDKs
>            Reporter: Michael Hackett
>         Attachments: bundle-header-patch
>
>
> The code to parse the manifest of plugin JARs assumes that the Bundle-SymbolicName field will be present and throws an exception if there isn't one. Perhaps this is an error in the plugin JAR if this field is missing but I have found at least one sample code bundle that lacked the Bundle-* fields (org.eclipse.soda.dk.rfid.write.plugin.samples_1.1.0.200710042240.jar, part of the DeviceKit SDK).
> I would say that, even if it the condition is illegal, the appropriate action is to simply skip the JAR, not fail for the entire run. The attached patch "looks before it leaps" with respect to the Bundle-SymbolicName field, which allows it to continue processing without the problem JAR.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira