[GitHub] [hive] deniskuzZ commented on a change in pull request #1979: HIVE-24785: Fix HIVE_COMPACTOR_COMPACT_MM property

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #1979:
URL: https://github.com/apache/hive/pull/1979#discussion_r576624589



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -469,6 +469,12 @@ private boolean isEligibleForCompaction(CompactionInfo ci, ShowCompactResponse c
             "=true so we will not compact it.");
         return false;
       }
+      if (AcidUtils.isInsertOnlyTable(t.getParameters()) && !HiveConf

Review comment:
       Does this config makes any sense or just adds extra hassle for end users - "Whether the compactor should compact insert-only tables. A safety switch."? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org