You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Cheolsoo Park <ch...@cloudera.com> on 2012/05/30 18:07:14 UTC

Review Request: SQOOP-490 Style error in the trunk

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5295/
-----------------------------------------------------------

Review request for Sqoop and Kathleen Ting.


Summary
-------

The following style error is introduced by SQOOP-488 in the trunk:

File src/java/org/apache/sqoop/tool/BaseSqoopTool.java
Unused import - org.apache.log4j.Category.


This addresses bug SQOOP-490.
    https://issues.apache.org/jira/browse/SQOOP-490


Diffs
-----

  /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1344075 

Diff: https://reviews.apache.org/r/5295/diff


Testing
-------


Thanks,

Cheolsoo

Re: Review Request: SQOOP-490 Style error in the trunk

Posted by Jarek Cecho <ja...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5295/#review8228
-----------------------------------------------------------

Ship it!


That's totally my fault, thank you for noticing and fixing sir.

- Jarek


On 2012-05-30 16:07:14, Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5295/
> -----------------------------------------------------------
> 
> (Updated 2012-05-30 16:07:14)
> 
> 
> Review request for Sqoop and Kathleen Ting.
> 
> 
> Summary
> -------
> 
> The following style error is introduced by SQOOP-488 in the trunk:
> 
> File src/java/org/apache/sqoop/tool/BaseSqoopTool.java
> Unused import - org.apache.log4j.Category.
> 
> 
> This addresses bug SQOOP-490.
>     https://issues.apache.org/jira/browse/SQOOP-490
> 
> 
> Diffs
> -----
> 
>   /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1344075 
> 
> Diff: https://reviews.apache.org/r/5295/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cheolsoo
> 
>